]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
dpll: zl3073x: Fix output pin registration
authorIvan Vecera <ivecera@redhat.com>
Mon, 27 Oct 2025 14:09:12 +0000 (15:09 +0100)
committerJakub Kicinski <kuba@kernel.org>
Wed, 29 Oct 2025 01:54:48 +0000 (18:54 -0700)
Currently, the signal format of an associated output is not considered
during output pin registration. As a result, the driver registers output
pins that are disabled by the signal format configuration.

Fix this by calling zl3073x_output_pin_is_enabled() to check whether
a given output pin should be registered or not.

Fixes: 75a71ecc2412 ("dpll: zl3073x: Register DPLL devices and pins")
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Link: https://patch.msgid.link/20251027140912.233152-1-ivecera@redhat.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/dpll/zl3073x/dpll.c

index 93dc93eec79edb0ba5b71bfa2598143bfabaa3e8..f93f9a4583243266b004176f2ceff619e3271e12 100644 (file)
@@ -1904,7 +1904,7 @@ zl3073x_dpll_pin_is_registrable(struct zl3073x_dpll *zldpll,
                }
 
                is_diff = zl3073x_out_is_diff(zldev, out);
-               is_enabled = zl3073x_out_is_enabled(zldev, out);
+               is_enabled = zl3073x_output_pin_is_enabled(zldev, index);
        }
 
        /* Skip N-pin if the corresponding input/output is differential */