journal: refuse skip parameter for sd_journal_next_skip() larger than INT_MAX

Fixes #17502.

diff --git a/man/sd_journal_next.xml b/man/sd_journal_next.xml
index 5f476fe3dfc57eeb6a4d7fa715e7e6f0965615a9..56083317371cd6d94c1d0478e17fc4a75296a3cf 100644 (file)
--- a/man/sd_journal_next.xml
+++ b/man/sd_journal_next.xml
@@ -78,9 +78,9 @@
     the read pointer back one entry.</para>
 
     <para><function>sd_journal_next_skip()</function> and
-    <function>sd_journal_previous_skip()</function> advance/set back
-    the read pointer by multiple entries at once, as specified in the
-    <varname>skip</varname> parameter.</para>
+    <function>sd_journal_previous_skip()</function> advance/set back the read pointer by multiple
+    entries at once, as specified in the <varname>skip</varname> parameter. The <varname>skip</varname>
+    parameter must be less than or equal to 2147483647 (2^31-1).</para>
 
     <para>The journal is strictly ordered by reception time, and hence
     advancing to the next entry guarantees that the entry then

diff --git a/src/journal/sd-journal.c b/src/journal/sd-journal.c
index dbbf919b7508bc6a87ab796f047db1031161d640..cb1ab88ca57d1ba38cb3731756dd843a50a54074 100644 (file)
--- a/src/journal/sd-journal.c
+++ b/src/journal/sd-journal.c
@@ -883,6 +883,7 @@ static int real_journal_next_skip(sd_journal *j, direction_t direction, uint64_t
 
         assert_return(j, -EINVAL);
         assert_return(!journal_pid_changed(j), -ECHILD);
+        assert_return(skip <= INT_MAX, -ERANGE);
 
         if (skip == 0) {
                 /* If this is not a discrete skip, then at least