]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
target/riscv: Fix exception type when VU accesses supervisor CSRs
authorXu Lu <luxu.kernel@bytedance.com>
Tue, 8 Jul 2025 06:07:20 +0000 (14:07 +0800)
committerMichael Tokarev <mjt@tls.msk.ru>
Wed, 30 Jul 2025 18:00:58 +0000 (21:00 +0300)
When supervisor CSRs are accessed from VU-mode, a virtual instruction
exception should be raised instead of an illegal instruction.

Fixes: c1fbcecb3a (target/riscv: Fix csr number based privilege checking)
Signed-off-by: Xu Lu <luxu.kernel@bytedance.com>
Reviewed-by: Anup Patel <apatel@ventanamicro.com>
Reviewed-by: Nutty Liu <liujingqi@lanxincomputing.com>
Message-ID: <20250708060720.7030-1-luxu.kernel@bytedance.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
(cherry picked from commit 30ef718423e8018723087cd17be0fd9c6dfa2e53)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
target/riscv/csr.c

index 79481883565d0a0e910104cf7eb891704ac0d0b0..f1c4c8c1b8efef4607bdc188efb635a1eee6d28f 100644 (file)
@@ -5498,7 +5498,7 @@ static inline RISCVException riscv_csrrw_check(CPURISCVState *env,
 
     csr_priv = get_field(csrno, 0x300);
     if (!env->debugger && (effective_priv < csr_priv)) {
-        if (csr_priv == (PRV_S + 1) && env->virt_enabled) {
+        if (csr_priv <= (PRV_S + 1) && env->virt_enabled) {
             return RISCV_EXCP_VIRT_INSTRUCTION_FAULT;
         }
         return RISCV_EXCP_ILLEGAL_INST;