]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/xe: Remove never used code in xe_vm_create()
authorGwan-gyeong Mun <gwan-gyeong.mun@intel.com>
Wed, 5 Nov 2025 01:13:11 +0000 (03:13 +0200)
committerMichał Winiarski <michal.winiarski@intel.com>
Wed, 5 Nov 2025 15:45:26 +0000 (16:45 +0100)
Clang is not happy with set but unused variable (this is visible
with `make LLVM=1` build:

  drivers/gpu/drm/xe/xe_vm.c:1462:11: error: variable 'number_tiles' set
  but not used [-Werror,-Wunused-but-set-variable]

The use of this variable was removed in the commit mentioned below as
"Fixes:" but only its declaration and update remain.
It seems like the variable is not used along with the assignment that
does not have side effects as far as I can see.
Remove those altogether.

Fixes: cb99e12ba8cb ("drm/xe: Decouple bind queue last fence from TLB invalidations")
Signed-off-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
Reviewed-by: Michał Winiarski <michal.winiarski@intel.com>
Link: https://patch.msgid.link/20251105011311.3177875-1-gwan-gyeong.mun@intel.com
Signed-off-by: Michał Winiarski <michal.winiarski@intel.com>
drivers/gpu/drm/xe/xe_vm.c

index ce2f2c063ebaa49068a90f77221909f92250ce6b..8fb5cc6a69ec34622e0e5a82ae165d8dbfb6195b 100644 (file)
@@ -1459,7 +1459,7 @@ struct xe_vm *xe_vm_create(struct xe_device *xe, u32 flags, struct xe_file *xef)
        struct xe_validation_ctx ctx;
        struct drm_exec exec;
        struct xe_vm *vm;
-       int err, number_tiles = 0;
+       int err;
        struct xe_tile *tile;
        u8 id;
 
@@ -1620,7 +1620,6 @@ struct xe_vm *xe_vm_create(struct xe_device *xe, u32 flags, struct xe_file *xef)
                                goto err_close;
                        }
                        vm->q[id] = q;
-                       number_tiles++;
                }
        }