]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/i915/dsi: debug log send packet sequence contents
authorJani Nikula <jani.nikula@intel.com>
Wed, 29 Oct 2025 08:46:03 +0000 (10:46 +0200)
committerJani Nikula <jani.nikula@intel.com>
Fri, 31 Oct 2025 10:46:34 +0000 (12:46 +0200)
This might help debug issues better than just debug logging the function
name.

v2: Debug log type as hex (Ville)

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patch.msgid.link/20251029084603.2254982-2-jani.nikula@intel.com
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/display/intel_dsi_vbt.c

index 63837406d99b73f373593eb1cb66e77c557558c2..fac8729e442c56b5668f68c0a8120a2848f7aeda 100644 (file)
@@ -107,8 +107,7 @@ static const u8 *mipi_exec_send_packet(struct intel_dsi *intel_dsi,
        u16 len;
        enum port port;
        ssize_t ret;
-
-       drm_dbg_kms(display->drm, "\n");
+       bool hs_mode;
 
        flags = *data++;
        type = *data++;
@@ -130,13 +129,18 @@ static const u8 *mipi_exec_send_packet(struct intel_dsi *intel_dsi,
                goto out;
        }
 
-       if ((flags >> MIPI_TRANSFER_MODE_SHIFT) & 1)
+       hs_mode = (flags >> MIPI_TRANSFER_MODE_SHIFT) & 1;
+       if (hs_mode)
                dsi_device->mode_flags &= ~MIPI_DSI_MODE_LPM;
        else
                dsi_device->mode_flags |= MIPI_DSI_MODE_LPM;
 
        dsi_device->channel = (flags >> MIPI_VIRTUAL_CHANNEL_SHIFT) & 3;
 
+       drm_dbg_kms(display->drm, "DSI packet: Port %c (seq %u), Flags 0x%02x, VC %u, %s, Type 0x%02x, Length %u, Data %*ph\n",
+                   port_name(port), seq_port, flags, dsi_device->channel,
+                   hs_mode ? "HS" : "LP", type, len, (int)len, data);
+
        switch (type) {
        case MIPI_DSI_GENERIC_SHORT_WRITE_0_PARAM:
                ret = mipi_dsi_generic_write(dsi_device, NULL, 0);