]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
mmc: core: Do a power cycle when the CMD11 fails
authorDooHyun Hwang <dh0421.hwang@samsung.com>
Wed, 10 Feb 2021 04:59:36 +0000 (13:59 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 11 May 2021 12:04:03 +0000 (14:04 +0200)
commit 147186f531ae49c18b7a9091a2c40e83b3d95649 upstream.

A CMD11 is sent to the SD/SDIO card to start the voltage switch procedure
into 1.8V I/O. According to the SD spec a power cycle is needed of the
card, if it turns out that the CMD11 fails. Let's fix this, to allow a
retry of the initialization without the voltage switch, to succeed.

Note that, whether it makes sense to also retry with the voltage switch
after the power cycle is a bit more difficult to know. At this point, we
treat it like the CMD11 isn't supported and therefore we skip it when
retrying.

Signed-off-by: DooHyun Hwang <dh0421.hwang@samsung.com>
Link: https://lore.kernel.org/r/20210210045936.7809-1-dh0421.hwang@samsung.com
Cc: stable@vger.kernel.org
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/mmc/core/core.c

index 26644b7ec13e3e508c4933cae09c322999a24121..af683aea47b6bd6f920517ced677bc69ba58b011 100644 (file)
@@ -1221,7 +1221,7 @@ int mmc_set_uhs_voltage(struct mmc_host *host, u32 ocr)
 
        err = mmc_wait_for_cmd(host, &cmd, 0);
        if (err)
-               return err;
+               goto power_cycle;
 
        if (!mmc_host_is_spi(host) && (cmd.resp[0] & R1_ERROR))
                return -EIO;