Add changes for [GL #1989]

diff --git a/CHANGES b/CHANGES
index 2403831aed25fd924751f7fd92b7ea079bf10afb..de17a40db217a13bdaa09e1feea45214f42a1569 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -1,3 +1,7 @@
+5464.  [bug]           Specifying saving more than 128 files when rolling
+                       dnstap / log files would cause buffer overflow.
+                       [GL #1989]
+
 5463.  [placeholder]
 
 5462.  [bug]           Move LMDB locking from LMDB itself to named. [GL #1976]

diff --git a/lib/isc/log.c b/lib/isc/log.c
index 9970431ba3b435cf2e6124584c4107eccda37b03..dc605d3e8dc62398489224b5b44549ab6038cfb4 100644 (file)
--- a/lib/isc/log.c
+++ b/lib/isc/log.c
@@ -1180,7 +1180,8 @@ remove_old_tsversions(isc_logfile_t *file, int versions) {
                                                memmove(&to_keep[i + 1],
                                                        &to_keep[i],
                                                        sizeof(to_keep[0]) *
-                                                       (versions - i - 1));
+                                                               (versions - i -
+                                                                1));
                                                to_keep[i] = version;
                                        }
                                }