]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
3.14-stable patches
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 May 2014 00:20:55 +0000 (17:20 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 May 2014 00:20:55 +0000 (17:20 -0700)
added patches:
rbd-fix-error-paths-in-rbd_img_request_fill.patch

queue-3.14/rbd-fix-error-paths-in-rbd_img_request_fill.patch [new file with mode: 0644]
queue-3.14/series

diff --git a/queue-3.14/rbd-fix-error-paths-in-rbd_img_request_fill.patch b/queue-3.14/rbd-fix-error-paths-in-rbd_img_request_fill.patch
new file mode 100644 (file)
index 0000000..b4b465f
--- /dev/null
@@ -0,0 +1,41 @@
+From 42dd037c08c7cd6e3e9af7824b0c1d063f838885 Mon Sep 17 00:00:00 2001
+From: Ilya Dryomov <ilya.dryomov@inktank.com>
+Date: Tue, 4 Mar 2014 11:57:17 +0200
+Subject: rbd: fix error paths in rbd_img_request_fill()
+
+From: Ilya Dryomov <ilya.dryomov@inktank.com>
+
+commit 42dd037c08c7cd6e3e9af7824b0c1d063f838885 upstream.
+
+Doing rbd_obj_request_put() in rbd_img_request_fill() error paths is
+not only insufficient, but also triggers an rbd_assert() in
+rbd_obj_request_destroy():
+
+    Assertion failure in rbd_obj_request_destroy() at line 1867:
+
+    rbd_assert(obj_request->img_request == NULL);
+
+rbd_img_obj_request_add() adds obj_requests to the img_request, the
+opposite is rbd_img_obj_request_del().  Use it.
+
+Fixes: http://tracker.ceph.com/issues/7327
+
+Signed-off-by: Ilya Dryomov <ilya.dryomov@inktank.com>
+Reviewed-by: Alex Elder <elder@linaro.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+---
+ drivers/block/rbd.c |    2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+--- a/drivers/block/rbd.c
++++ b/drivers/block/rbd.c
+@@ -2253,7 +2253,7 @@ out_partial:
+       rbd_obj_request_put(obj_request);
+ out_unwind:
+       for_each_obj_request_safe(img_request, obj_request, next_obj_request)
+-              rbd_obj_request_put(obj_request);
++              rbd_img_obj_request_del(img_request, obj_request);
+       return -ENOMEM;
+ }
index 51891ad9a9de6a486b44ad196a2ee1150ead6147..3e093e74f2f5351622baab49c99f5ef80cd7031d 100644 (file)
@@ -12,3 +12,4 @@ netfilter-can-t-fail-and-free-after-table-replacement.patch
 netfilter-nf_tables-set-names-cannot-be-larger-than-15-bytes.patch
 x86-preempt-fix-preemption-for-i386.patch
 tracepoint-do-not-waste-memory-on-mods-with-no-tracepoints.patch
+rbd-fix-error-paths-in-rbd_img_request_fill.patch