]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
creds: reorder option cases to match --help output
authorZbigniew Jędrzejewski-Szmek <zbyszek@amutable.com>
Tue, 14 Apr 2026 14:50:55 +0000 (16:50 +0200)
committerZbigniew Jędrzejewski-Szmek <zbyszek@amutable.com>
Thu, 16 Apr 2026 14:55:08 +0000 (16:55 +0200)
Co-developed-by: Claude Opus 4.6 <noreply@anthropic.com>
src/creds/creds.c

index 3b1cc8e86b64ca8dbfe2d611e1c5fa536857837b..ed087d8cf1d2a2c57bca07ceaa12898deedaa9cd 100644 (file)
@@ -949,6 +949,34 @@ static int parse_argv(int argc, char *argv[]) {
                         arg_pretty = true;
                         break;
 
+                case ARG_NAME:
+                        if (isempty(optarg)) {
+                                arg_name = NULL;
+                                arg_name_any = true;
+                                break;
+                        }
+
+                        if (!credential_name_valid(optarg))
+                                return log_error_errno(SYNTHETIC_ERRNO(EINVAL), "Invalid credential name: %s", optarg);
+
+                        arg_name = optarg;
+                        arg_name_any = false;
+                        break;
+
+                case ARG_TIMESTAMP:
+                        r = parse_timestamp(optarg, &arg_timestamp);
+                        if (r < 0)
+                                return log_error_errno(r, "Failed to parse timestamp: %s", optarg);
+
+                        break;
+
+                case ARG_NOT_AFTER:
+                        r = parse_timestamp(optarg, &arg_not_after);
+                        if (r < 0)
+                                return log_error_errno(r, "Failed to parse --not-after= timestamp: %s", optarg);
+
+                        break;
+
                 case ARG_WITH_KEY:
                         if (streq(optarg, "help")) {
                                 if (arg_legend)
@@ -1010,34 +1038,6 @@ static int parse_argv(int argc, char *argv[]) {
 
                         break;
 
-                case ARG_NAME:
-                        if (isempty(optarg)) {
-                                arg_name = NULL;
-                                arg_name_any = true;
-                                break;
-                        }
-
-                        if (!credential_name_valid(optarg))
-                                return log_error_errno(SYNTHETIC_ERRNO(EINVAL), "Invalid credential name: %s", optarg);
-
-                        arg_name = optarg;
-                        arg_name_any = false;
-                        break;
-
-                case ARG_TIMESTAMP:
-                        r = parse_timestamp(optarg, &arg_timestamp);
-                        if (r < 0)
-                                return log_error_errno(r, "Failed to parse timestamp: %s", optarg);
-
-                        break;
-
-                case ARG_NOT_AFTER:
-                        r = parse_timestamp(optarg, &arg_not_after);
-                        if (r < 0)
-                                return log_error_errno(r, "Failed to parse --not-after= timestamp: %s", optarg);
-
-                        break;
-
                 case ARG_USER:
                         if (!uid_is_valid(arg_uid))
                                 arg_uid = getuid();