]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/sched: Fix comment in drm_sched_run_job_work()
authorPhilipp Stanner <phasta@kernel.org>
Tue, 28 Oct 2025 13:46:01 +0000 (14:46 +0100)
committerPhilipp Stanner <phasta@kernel.org>
Fri, 31 Oct 2025 10:09:00 +0000 (11:09 +0100)
drm_sched_run_job_work() contains a comment which explains that an
entity being NULL means that there is no more work to do. It can,
however, also mean that there is work, but the scheduler doesn't have
enough credits to process the jobs right now.

Provide this detail in the comment.

Reviewed-by: Matthew Brost <matthew.brost@intel.com>
Signed-off-by: Philipp Stanner <phasta@kernel.org>
Link: https://patch.msgid.link/20251028134602.94125-3-phasta@kernel.org
drivers/gpu/drm/scheduler/sched_main.c

index c39f0245e3a97808173df55c4b584ecdf7d965ec..492e8af639dbe795e57b9363a6fb5a3818df5e84 100644 (file)
@@ -1237,8 +1237,13 @@ static void drm_sched_run_job_work(struct work_struct *w)
 
        /* Find entity with a ready job */
        entity = drm_sched_select_entity(sched);
-       if (!entity)
-               return; /* No more work */
+       if (!entity) {
+               /*
+                * Either no more work to do, or the next ready job needs more
+                * credits than the scheduler has currently available.
+                */
+               return;
+       }
 
        sched_job = drm_sched_entity_pop_job(entity);
        if (!sched_job) {