]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: phy: realtek: use LEDCR page number define on RTL8211F
authorAleksander Jan Bajkowski <olek2@wp.pl>
Sat, 11 Apr 2026 10:51:45 +0000 (12:51 +0200)
committerJakub Kicinski <kuba@kernel.org>
Mon, 13 Apr 2026 23:38:25 +0000 (16:38 -0700)
Replace the magic number with an existing define for the LEDCR
register page number on the RTL8211F.

Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
Reviewed-by: Daniel Golle <daniel@makrotopia.org>
Link: https://patch.msgid.link/20260411105150.184577-1-olek2@wp.pl
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/realtek/realtek_main.c

index 9c26531abe4a808414852f959730136842b51b85..79c867ef64dad07b7ba9bfacc816510ab56c9c6c 100644 (file)
@@ -1012,7 +1012,7 @@ static int rtl8211f_led_hw_control_get(struct phy_device *phydev, u8 index,
        if (index >= RTL8211x_LED_COUNT)
                return -EINVAL;
 
-       val = phy_read_paged(phydev, 0xd04, RTL8211F_LEDCR);
+       val = phy_read_paged(phydev, RTL8211F_LEDCR_PAGE, RTL8211F_LEDCR);
        if (val < 0)
                return val;
 
@@ -1074,7 +1074,8 @@ static int rtl8211f_led_hw_control_set(struct phy_device *phydev, u8 index,
        reg <<= RTL8211F_LEDCR_SHIFT * index;
        reg |= RTL8211F_LEDCR_MODE;      /* Mode B */
 
-       return phy_modify_paged(phydev, 0xd04, RTL8211F_LEDCR, mask, reg);
+       return phy_modify_paged(phydev, RTL8211F_LEDCR_PAGE, RTL8211F_LEDCR,
+                               mask, reg);
 }
 
 static int rtl8211e_led_hw_control_get(struct phy_device *phydev, u8 index,