ALSA: scarlett2: Add missing error check to scarlett2_config_save()

[ Upstream commit 5f6ff6931a1c0065a55448108940371e1ac8075f ]

scarlett2_config_save() was ignoring the return value from
scarlett2_usb(). As this function is not called from user-space we
can't return the error, so call usb_audio_err() instead.

Signed-off-by: Geoffrey D. Bennett <g@b4.vu>
Fixes: 9e4d5c1be21f ("ALSA: usb-audio: Scarlett Gen 2 mixer interface")
Link: https://lore.kernel.org/r/bf0a15332d852d7825fa6da87d2a0d9c0b702053.1703001053.git.g@b4.vu
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/sound/usb/mixer_scarlett_gen2.c b/sound/usb/mixer_scarlett_gen2.c
index d260be8cb6bc03e8c5c2b2a3dc5ff5759ff2588d..64cfe2d6045ec57c79b8f3ac5a257182fd6b2c5d 100644 (file)
--- a/sound/usb/mixer_scarlett_gen2.c
+++ b/sound/usb/mixer_scarlett_gen2.c
@@ -1337,9 +1337,11 @@ static void scarlett2_config_save(struct usb_mixer_interface *mixer)
 {
        __le32 req = cpu_to_le32(SCARLETT2_USB_CONFIG_SAVE);
 
-       scarlett2_usb(mixer, SCARLETT2_USB_DATA_CMD,
-                     &req, sizeof(u32),
-                     NULL, 0);
+       int err = scarlett2_usb(mixer, SCARLETT2_USB_DATA_CMD,
+                               &req, sizeof(u32),
+                               NULL, 0);
+       if (err < 0)
+               usb_audio_err(mixer->chip, "config save failed: %d\n", err);
 }
 
 /* Delayed work to save config */