It's highly unlikely, though possible for PyEval_Get*() to return NULLs.

So be safe and do an XINCREF.

Klocwork # 221-222.

diff --git a/Python/bltinmodule.c b/Python/bltinmodule.c
index 58dc7c956b92ef6f419b7d70c98c3b5ec4edd7b2..5bae619774e70f184cfec85424647ab951050894 100644 (file)
--- a/Python/bltinmodule.c
+++ b/Python/bltinmodule.c
@@ -759,7 +759,7 @@ builtin_globals(PyObject *self)
        PyObject *d;
 
        d = PyEval_GetGlobals();
-       Py_INCREF(d);
+       Py_XINCREF(d);
        return d;
 }
 
@@ -1190,7 +1190,7 @@ builtin_locals(PyObject *self)
        PyObject *d;
 
        d = PyEval_GetLocals();
-       Py_INCREF(d);
+       Py_XINCREF(d);
        return d;
 }