]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
resolved: return regular varlink invalid parameter error if more is not specified...
authorLennart Poettering <lennart@poettering.net>
Wed, 28 Sep 2022 09:44:57 +0000 (11:44 +0200)
committerLennart Poettering <lennart@poettering.net>
Wed, 28 Sep 2022 20:51:51 +0000 (22:51 +0200)
No point in returning EINVAL if we can just return a proper varlink
invalid parameter error

src/resolve/resolved-varlink.c

index 259a4bb7c6a97d54726f0e1d70e4577fa6639afc..75628f054c7139ceeaba08b2f580ee5a7b642910 100644 (file)
@@ -539,9 +539,9 @@ static int vl_method_subscribe_dns_resolves(Varlink *link, JsonVariant *paramete
 
         m = ASSERT_PTR(varlink_server_get_userdata(varlink_get_server(link)));
 
-        /* if the client didn't set the more flag, return an empty response and close the connection */
+        /* if the client didn't set the more flag, it is using us incorrectly */
         if (!FLAGS_SET(flags, VARLINK_METHOD_MORE))
-                return varlink_error_errno(link, EINVAL);
+                return varlink_error_invalid_parameter(link, NULL);
 
         if (json_variant_elements(parameters) > 0)
                 return varlink_error_invalid_parameter(link, parameters);