copy: fix wrong argument passed to S_ISREG() in copy_file_fd_full()

Follow-up for 2f782044986a30bf73f1fe00209dbd204b3efe33.

diff --git a/src/shared/copy.c b/src/shared/copy.c
index 09417063562131c4245c91fd052a316d93defc45..cc76465fb1c549d9594a08421cdeb3aa936d3648 100644 (file)
--- a/src/shared/copy.c
+++ b/src/shared/copy.c
@@ -1214,7 +1214,10 @@ int copy_file_fd_full(
         if (r < 0)
                 return r;
 
-        if (S_ISREG(fdt)) {
+        /* Make sure to copy file attributes only over if target is a regular
+         * file (so that copying a file to /dev/null won't alter the access
+         * mode/ownership of that device node...) */
+        if (S_ISREG(st.st_mode)) {
                 (void) copy_times(fdf, fdt, copy_flags);
                 (void) copy_xattr(fdf, fdt, copy_flags);
         }