]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
rtc: test: Fix invalid format specifier.
authorDavid Gow <davidgow@google.com>
Wed, 21 Feb 2024 09:27:18 +0000 (17:27 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 27 Jun 2025 10:04:24 +0000 (11:04 +0100)
commit 8a904a3caa88118744062e872ae90f37748a8fd8 upstream.

'days' is a s64 (from div_s64), and so should use a %lld specifier.

This was found by extending KUnit's assertion macros to use gcc's
__printf attribute.

Fixes: 1d1bb12a8b18 ("rtc: Improve performance of rtc_time64_to_tm(). Add tests.")
Signed-off-by: David Gow <davidgow@google.com>
Tested-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Justin Stitt <justinstitt@google.com>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/rtc/lib_test.c

index 2124b67a2f4396459ea72a997336df960f2de407..fa6fd2875b3d97a498a60b271ceb5acd20d5dd47 100644 (file)
@@ -54,7 +54,7 @@ static void rtc_time64_to_tm_test_date_range(struct kunit *test)
 
                days = div_s64(secs, 86400);
 
-               #define FAIL_MSG "%d/%02d/%02d (%2d) : %ld", \
+               #define FAIL_MSG "%d/%02d/%02d (%2d) : %lld", \
                        year, month, mday, yday, days
 
                KUNIT_ASSERT_EQ_MSG(test, year - 1900, result.tm_year, FAIL_MSG);