]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
selftests/bpf: Fix unintentional switch case fall through
authorMykyta Yatsenko <yatsenko@meta.com>
Tue, 17 Jun 2025 12:15:36 +0000 (13:15 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 15 Aug 2025 10:13:39 +0000 (12:13 +0200)
[ Upstream commit 66ab68c9de89672366fdc474f4f185bb58cecf2d ]

Break from switch expression after parsing -n CLI argument in veristat,
instead of falling through and enabling comparison mode.

Fixes: a5c57f81eb2b ("veristat: add ability to set BPF_F_TEST_SANITY_STRICT flag with -r flag")
Signed-off-by: Mykyta Yatsenko <yatsenko@meta.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Acked-by: Yonghong Song <yonghong.song@linux.dev>
Link: https://lore.kernel.org/bpf/20250617121536.1320074-1-mykyta.yatsenko5@gmail.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
tools/testing/selftests/bpf/veristat.c

index 1ec5c4c47235e7d625d3602816606561c68f9a29..7b6b9c4cadb570b87f5121f18e64c6ffc71c53d2 100644 (file)
@@ -309,6 +309,7 @@ static error_t parse_arg(int key, char *arg, struct argp_state *state)
                        fprintf(stderr, "invalid top N specifier: %s\n", arg);
                        argp_usage(state);
                }
+               break;
        case 'C':
                env.comparison_mode = true;
                break;