]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
dm-pcache: use int type to store negative error codes
authorQianfeng Rong <rongqianfeng@vivo.com>
Fri, 29 Aug 2025 13:37:48 +0000 (21:37 +0800)
committerMikulas Patocka <mpatocka@redhat.com>
Tue, 2 Sep 2025 09:19:12 +0000 (11:19 +0200)
Change the 'ret' variable from u32 to int to store negative error codes or
zero returned by cache_kset_close().

Storing the negative error codes in unsigned type, doesn't cause an issue
at runtime but it's ugly. Additionally, assigning negative error codes to
unsigned type may trigger a GCC warning when the -Wsign-conversion flag
is enabled.

No effect on runtime.

Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
drivers/md/dm-pcache/cache_req.c

index bd5cace7de7126b0910b57b299b3dfb7555b6719..27f94c1fa968c6d376feb6cf045e0f128eb2e850 100644 (file)
@@ -805,7 +805,8 @@ err:
 int cache_flush(struct pcache_cache *cache)
 {
        struct pcache_cache_kset *kset;
-       u32 i, ret;
+       int ret;
+       u32 i;
 
        for (i = 0; i < cache->n_ksets; i++) {
                kset = get_kset(cache, i);