]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s4:drs:test:getncchanges: remove timeout failure
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Thu, 8 Aug 2024 23:29:11 +0000 (11:29 +1200)
committerDouglas Bagnall <dbagnall@samba.org>
Wed, 28 Aug 2024 04:24:39 +0000 (04:24 +0000)
We don't need a timeout failure any more, since replication should
always work. Leaving the timeout in might sometimes cause a flapping
test if replication is being slow for some reason.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15701

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jennifer Sutton <josutton@catalyst.net.nz>
source4/torture/drs/python/getncchanges.py

index d05c38d495039638f58d8b9eac3792c0c1b2a39d..eb21a67bfa782cfaffd7cc2e1a77daaa11094277 100644 (file)
@@ -33,7 +33,6 @@ import samba.tests
 import ldb
 from ldb import SCOPE_BASE
 import random
-import time
 
 from samba.dcerpc import drsuapi, misc
 from samba import WERRORError
@@ -58,7 +57,6 @@ class DrsReplicaSyncIntegrityTestCase(drs_base.DrsBaseTestCase):
 
         self.default_conn = DcConnection(self, self.ldb_dc2, self.dnsname_dc2)
         self.set_dc_connection(self.default_conn)
-        self.start_time = time.time()
 
     def init_test_state(self):
         self.rxd_dn_list = []
@@ -360,9 +358,6 @@ class DrsReplicaSyncIntegrityTestCase(drs_base.DrsBaseTestCase):
 
     def replication_complete(self):
         """Returns True if the current/last replication cycle is complete"""
-        now = time.time()
-        if now - self.start_time > 30:
-            self.fail("we seem to be in an eternal loop")
 
         if self.last_ctr is None or self.last_ctr.more_data:
             return False