]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
Remove a strlen check that will never kick in
authorVolker Lendecke <vl@samba.org>
Fri, 27 Jun 2008 09:13:07 +0000 (11:13 +0200)
committerVolker Lendecke <vl@samba.org>
Fri, 27 Jun 2008 09:23:20 +0000 (11:23 +0200)
strlen(str)<2 will be caught by the explicit tests for str[0] and str[1] in the
lines above this.

Jerry, please check!

Volker

source/nsswitch/libwbclient/wbc_sid.c

index b0909263fcb6bc3661948ba869835e3678f51e94..eb115e129765727429d44b96c373367f535f5937 100644 (file)
@@ -102,8 +102,7 @@ wbcErr wbcStringToSid(const char *str,
 
        if (!str
            || (str[0]!='S' && str[0]!='s')
-           || (str[1]!='-')
-           || (strlen(str)<2))
+           || (str[1]!='-'))
        {
                wbc_status = WBC_ERR_INVALID_PARAM;
                BAIL_ON_WBC_ERROR(wbc_status);