]> git.ipfire.org Git - thirdparty/u-boot.git/commitdiff
qcom: rpmh: don't error for SLEEP requests
authorCasey Connolly <casey.connolly@linaro.org>
Fri, 20 Mar 2026 15:45:41 +0000 (16:45 +0100)
committerCasey Connolly <casey.connolly@linaro.org>
Tue, 24 Mar 2026 10:49:17 +0000 (11:49 +0100)
Just stub out non-active votes, if we return an error the caller may
propagate it and not send its active vote. Since we don't suspend
there's no risk of us entering a broken state due to missing votes.

Link: https://patch.msgid.link/20260320-casey-qcom-rpmh-serial-fixes-v1-2-b81d05832eec@linaro.org
Signed-off-by: Casey Connolly <casey.connolly@linaro.org>
drivers/soc/qcom/rpmh-rsc.c
drivers/soc/qcom/rpmh.c

index dce61f262292e390987902f8490f2bb31e3c8648..0b821cc6f9d8cf4ff869545bf1216dcc107ad0e8 100644 (file)
@@ -261,8 +261,8 @@ static struct tcs_group *get_tcs_for_msg(struct rsc_drv *drv,
         * just always used the first active TCS.
         */
        if (msg->state != RPMH_ACTIVE_ONLY_STATE) {
-               log_err("WARN: only ACTIVE_ONLY state supported\n");
-               return ERR_PTR(-EINVAL);
+               log_debug("WARN: only ACTIVE_ONLY state supported\n");
+               return NULL;
        }
 
        return &drv->tcs[ACTIVE_TCS];
@@ -390,8 +390,8 @@ int rpmh_rsc_send_data(struct rsc_drv *drv, const struct tcs_request *msg)
        u32 val;
 
        tcs = get_tcs_for_msg(drv, msg);
-       if (IS_ERR(tcs))
-               return PTR_ERR(tcs);
+       if (IS_ERR_OR_NULL(tcs))
+               return 0;
 
        /* U-Boot is single-threaded, always use the first TCS as we'll never conflict */
        tcs_id = tcs->offset;
index 8c222324c66d7fc5388a7fc3d51b8dc1232cd254..b55e23c4417d3b68d19d310ef3276436d031cbd9 100644 (file)
@@ -60,8 +60,8 @@ static int __rpmh_write(const struct udevice *dev, enum rpmh_state state,
        struct rpmh_ctrlr *ctrlr = get_rpmh_ctrlr(dev);
 
        if (state != RPMH_ACTIVE_ONLY_STATE) {
-               log_err("only ACTIVE_ONLY state supported\n");
-               return -EINVAL;
+               log_debug("WARN: Only ACTIVE_ONLY state supported\n");
+               return 0;
        }
 
        return rpmh_rsc_send_data(ctrlr_to_drv(ctrlr), &rpm_msg->msg);