]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
source3/lib: Properly log the change in capability
authorAnoop C S <anoopcs@samba.org>
Fri, 19 Jan 2024 10:50:36 +0000 (16:20 +0530)
committerAnoop C S <anoopcs@samba.org>
Sat, 20 Jan 2024 18:43:10 +0000 (18:43 +0000)
We used to log the following message for both adding and dropping
capability:

DBG_INFO("added capability %d\n", capability);

For better clarity indicate the change as "added" or "dropped"
based on available functional arguments.

Signed-off-by: Anoop C S <anoopcs@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
Autobuild-User(master): Anoop C S <anoopcs@samba.org>
Autobuild-Date(master): Sat Jan 20 18:43:10 UTC 2024 on atb-devel-224

source3/lib/system.c

index 18dc6989372e75557ecf420b1e4156b100dbcc11..1ec0ae9b1d538fec7e0ceed5089ac177f70e328b 100644 (file)
@@ -628,12 +628,14 @@ static bool set_process_capability(enum smbd_capability capability,
        cap_set_flag(cap, CAP_INHERITABLE, num_cap_vals, cap_vals, CAP_CLEAR);
 
        if (cap_set_proc(cap) == -1) {
-               DBG_ERR("adding capability %d: cap_set_proc failed: %s\n",
+               DBG_ERR("%s capability %d: cap_set_proc failed: %s\n",
+                       enable ? "adding" : "dropping",
                        capability, strerror(errno));
                cap_free(cap);
                return False;
        }
-       DBG_INFO("added capability %d\n", capability);
+       DBG_INFO("%s capability %d\n",
+                enable ? "added" : "dropped", capability);
 
        cap_free(cap);
        return True;