Fixes for 5.4

Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/queue-5.4/series b/queue-5.4/series
index ed5c1caa4efc29ab0c4863ad045920888b7c188a..4e7d5ff123d85c13f3594ab5f98d9bac3f88ee88 100644 (file)
--- a/queue-5.4/series
+++ b/queue-5.4/series
@@ -65,3 +65,5 @@ powerpc-watchpoints-annotate-atomic-context-in-more-.patch
 ncsi-propagate-carrier-gain-loss-events-to-the-ncsi-.patch
 fbdev-sh7760fb-depend-on-fb-y.patch
 nvme-pci-do-not-set-the-numa-node-of-device-if-it-ha.patch
+watchdog-itco_wdt-no-need-to-stop-the-timer-in-probe.patch
+watchdog-itco_wdt-set-no_reboot-if-the-watchdog-is-n.patch

diff --git a/queue-5.4/watchdog-itco_wdt-no-need-to-stop-the-timer-in-probe.patch b/queue-5.4/watchdog-itco_wdt-no-need-to-stop-the-timer-in-probe.patch
new file mode 100644 (file)
index 0000000..f53f5c5
--- /dev/null
+++ b/queue-5.4/watchdog-itco_wdt-no-need-to-stop-the-timer-in-probe.patch
@@ -0,0 +1,58 @@
+From 647f89fe13852802d6bc85bcd0a2b2f106cfa82d Mon Sep 17 00:00:00 2001
+From: Sasha Levin <sashal@kernel.org>
+Date: Mon, 2 Oct 2023 09:05:34 +0200
+Subject: watchdog: iTCO_wdt: No need to stop the timer in probe
+
+From: Mika Westerberg <mika.westerberg@linux.intel.com>
+
+commit 1ae3e78c08209ac657c59f6f7ea21bbbd7f6a1d4 upstream.
+
+The watchdog core can handle pinging of the watchdog before userspace
+opens the device. For this reason instead of stopping the timer, just
+mark it as running and let the watchdog core take care of it.
+
+Cc: Malin Jonsson <malin.jonsson@ericsson.com>
+Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
+Reviewed-by: Guenter Roeck <linux@roeck-us.net>
+Link: https://lore.kernel.org/r/20210921102900.61586-1-mika.westerberg@linux.intel.com
+Signed-off-by: Guenter Roeck <linux@roeck-us.net>
+Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
+Signed-off-by: Sasha Levin <sashal@kernel.org>
+---
+ drivers/watchdog/iTCO_wdt.c | 13 +++++++++++--
+ 1 file changed, 11 insertions(+), 2 deletions(-)
+
+diff --git a/drivers/watchdog/iTCO_wdt.c b/drivers/watchdog/iTCO_wdt.c
+index e707c4797f76e..22091a775f49f 100644
+--- a/drivers/watchdog/iTCO_wdt.c
++++ b/drivers/watchdog/iTCO_wdt.c
+@@ -413,6 +413,16 @@ static unsigned int iTCO_wdt_get_timeleft(struct watchdog_device *wd_dev)
+       return time_left;
+ }
+ 
++static void iTCO_wdt_set_running(struct iTCO_wdt_private *p)
++{
++      u16 val;
++
++      /* Bit 11: TCO Timer Halt -> 0 = The TCO timer is * enabled */
++      val = inw(TCO1_CNT(p));
++      if (!(val & BIT(11)))
++              set_bit(WDOG_HW_RUNNING, &p->wddev.status);
++}
++
+ /*
+  *    Kernel Interfaces
+  */
+@@ -555,8 +565,7 @@ static int iTCO_wdt_probe(struct platform_device *pdev)
+       watchdog_set_drvdata(&p->wddev, p);
+       platform_set_drvdata(pdev, p);
+ 
+-      /* Make sure the watchdog is not running */
+-      iTCO_wdt_stop(&p->wddev);
++      iTCO_wdt_set_running(p);
+ 
+       /* Check that the heartbeat value is within it's range;
+          if not reset to the default */
+-- 
+2.40.1
+

diff --git a/queue-5.4/watchdog-itco_wdt-set-no_reboot-if-the-watchdog-is-n.patch b/queue-5.4/watchdog-itco_wdt-set-no_reboot-if-the-watchdog-is-n.patch
new file mode 100644 (file)
index 0000000..0cc62d9
--- /dev/null
+++ b/queue-5.4/watchdog-itco_wdt-set-no_reboot-if-the-watchdog-is-n.patch
@@ -0,0 +1,96 @@
+From 61aa9132940155c3df9ff2f394ed752bfc1709dd Mon Sep 17 00:00:00 2001
+From: Sasha Levin <sashal@kernel.org>
+Date: Mon, 2 Oct 2023 09:05:35 +0200
+Subject: watchdog: iTCO_wdt: Set NO_REBOOT if the watchdog is not already
+ running
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+From: Mika Westerberg <mika.westerberg@linux.intel.com>
+
+commit ef9b7bf52c2f47f0a9bf988543c577b92c92d15e upstream.
+
+Daniel reported that the commit 1ae3e78c0820 ("watchdog: iTCO_wdt: No
+need to stop the timer in probe") makes QEMU implementation of the iTCO
+watchdog not to trigger reboot anymore when NO_REBOOT flag is initially
+cleared using this option (in QEMU command line):
+
+  -global ICH9-LPC.noreboot=false
+
+The problem with the commit is that it left the unconditional setting of
+NO_REBOOT that is not cleared anymore when the kernel keeps pinging the
+watchdog (as opposed to the previous code that called iTCO_wdt_stop()
+that cleared it).
+
+Fix this so that we only set NO_REBOOT if the watchdog was not initially
+running.
+
+Fixes: 1ae3e78c0820 ("watchdog: iTCO_wdt: No need to stop the timer in probe")
+Reported-by: Daniel P. Berrangé <berrange@redhat.com>
+Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
+Tested-by: Daniel P. Berrangé <berrange@redhat.com>
+Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
+Reviewed-by: Guenter Roeck <linux@roeck-us.net>
+Link: https://lore.kernel.org/r/20221028062750.45451-1-mika.westerberg@linux.intel.com
+Signed-off-by: Guenter Roeck <linux@roeck-us.net>
+Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
+Signed-off-by: Sasha Levin <sashal@kernel.org>
+---
+ drivers/watchdog/iTCO_wdt.c | 21 ++++++++++++++-------
+ 1 file changed, 14 insertions(+), 7 deletions(-)
+
+diff --git a/drivers/watchdog/iTCO_wdt.c b/drivers/watchdog/iTCO_wdt.c
+index 22091a775f49f..134237d8b8fca 100644
+--- a/drivers/watchdog/iTCO_wdt.c
++++ b/drivers/watchdog/iTCO_wdt.c
+@@ -413,14 +413,18 @@ static unsigned int iTCO_wdt_get_timeleft(struct watchdog_device *wd_dev)
+       return time_left;
+ }
+ 
+-static void iTCO_wdt_set_running(struct iTCO_wdt_private *p)
++/* Returns true if the watchdog was running */
++static bool iTCO_wdt_set_running(struct iTCO_wdt_private *p)
+ {
+       u16 val;
+ 
+-      /* Bit 11: TCO Timer Halt -> 0 = The TCO timer is * enabled */
++      /* Bit 11: TCO Timer Halt -> 0 = The TCO timer is enabled */
+       val = inw(TCO1_CNT(p));
+-      if (!(val & BIT(11)))
++      if (!(val & BIT(11))) {
+               set_bit(WDOG_HW_RUNNING, &p->wddev.status);
++              return true;
++      }
++      return false;
+ }
+ 
+ /*
+@@ -511,9 +515,6 @@ static int iTCO_wdt_probe(struct platform_device *pdev)
+               return -ENODEV; /* Cannot reset NO_REBOOT bit */
+       }
+ 
+-      /* Set the NO_REBOOT bit to prevent later reboots, just for sure */
+-      p->update_no_reboot_bit(p->no_reboot_priv, true);
+-
+       if (turn_SMI_watchdog_clear_off >= p->iTCO_version) {
+               /*
+                * Bit 13: TCO_EN -> 0
+@@ -565,7 +566,13 @@ static int iTCO_wdt_probe(struct platform_device *pdev)
+       watchdog_set_drvdata(&p->wddev, p);
+       platform_set_drvdata(pdev, p);
+ 
+-      iTCO_wdt_set_running(p);
++      if (!iTCO_wdt_set_running(p)) {
++              /*
++               * If the watchdog was not running set NO_REBOOT now to
++               * prevent later reboots.
++               */
++              p->update_no_reboot_bit(p->no_reboot_priv, true);
++      }
+ 
+       /* Check that the heartbeat value is within it's range;
+          if not reset to the default */
+-- 
+2.40.1
+