]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
auth: auth-request - Remove auth_request_new_dummy()
authorStephan Bosch <stephan.bosch@open-xchange.com>
Sun, 19 Nov 2023 00:08:53 +0000 (01:08 +0100)
committertimo.sirainen <timo.sirainen@open-xchange.com>
Thu, 9 Oct 2025 08:41:22 +0000 (08:41 +0000)
It is no longer different from auth_request_new()

src/auth/auth-master-connection.c
src/auth/auth-request.c
src/auth/auth-worker-server.c
src/auth/test-lua.c

index cdf3cfd3d140a8f4d411d274c36bbdf08f059fe9..f0cef680c1a294eead5bdab3a2ea1304eaef73b9 100644 (file)
@@ -195,7 +195,7 @@ static int master_input_auth_request(struct auth_master_connection *conn,
                return -1;
        }
 
-       auth_request = auth_request_new_dummy(auth_event);
+       auth_request = auth_request_new(auth_event);
        auth_request->id = id;
        auth_request->master = conn;
        auth_master_connection_ref(conn);
@@ -618,7 +618,7 @@ static int master_input_list(struct auth_master_connection *conn,
                return 1;
        }
 
-       auth_request = auth_request_new_dummy(auth_event);
+       auth_request = auth_request_new(auth_event);
        auth_request->id = id;
        auth_request->master = conn;
        auth_master_connection_ref(conn);
index 9a894948780db9914cfe185fc9573502e879d996..3bc0f555e9f299dd9d22eed9714b75cd9cf0a939 100644 (file)
@@ -162,19 +162,6 @@ struct auth_request *auth_request_new(struct event *parent_event)
        return request;
 }
 
-struct auth_request *auth_request_new_dummy(struct event *parent_event)
-{
-       struct auth_request *request;
-       pool_t pool;
-
-       pool = pool_alloconly_create(MEMPOOL_GROWING"auth_request", 1024);
-       request = p_new(pool, struct auth_request, 1);
-       request->pool = pool;
-
-       auth_request_post_alloc_init(request, parent_event);
-       return request;
-}
-
 void auth_request_set_state(struct auth_request *request,
                            enum auth_request_state state)
 {
index 118a0c68de6fb48ce5584a427cda927308c6f11b..1694102a6e3cd00f8ce69eabbc7180eef5399d48 100644 (file)
@@ -137,7 +137,7 @@ bool auth_worker_auth_request_new(struct auth_worker_command *cmd, unsigned int
        struct auth_request *auth_request;
        const char *key, *value;
 
-       auth_request = auth_request_new_dummy(cmd->event);
+       auth_request = auth_request_new(cmd->event);
 
        cmd->server->refcount++;
        auth_request->context = cmd;
index f64f47eea5844ee00c6f1f1e4d87a3c237461df2..ab177e9b46df9ae4c104496a978429b5fad44cc6 100644 (file)
@@ -18,7 +18,7 @@ static struct auth_settings test_lua_auth_set = {
 static struct auth_request *test_db_lua_auth_request_new(void)
 {
        const char *error;
-       struct auth_request *req = auth_request_new_dummy(NULL);
+       struct auth_request *req = auth_request_new(NULL);
        req->set = global_auth_settings;
        struct event *event = event_create(req->event);
        array_push_back(&req->authdb_event, &event);