- add an exclusion here that helps with the case of 3rd party

test suite redefining an existing test in test_suite

diff --git a/lib/sqlalchemy/testing/plugin/pytestplugin.py b/lib/sqlalchemy/testing/plugin/pytestplugin.py
index 4bbc8ed9a2ea2f1f6c22808748dba24af5a09141..fbab4966cbb4536b37e6928c41bb0f5b96594f45 100644 (file)
--- a/lib/sqlalchemy/testing/plugin/pytestplugin.py
+++ b/lib/sqlalchemy/testing/plugin/pytestplugin.py
@@ -84,7 +84,8 @@ def pytest_collection_modifyitems(session, config, items):
     rebuilt_items = collections.defaultdict(list)
     items[:] = [
         item for item in
-        items if isinstance(item.parent, pytest.Instance)]
+        items if isinstance(item.parent, pytest.Instance)
+        and not item.parent.parent.name.startswith("_")]
     test_classes = set(item.parent for item in items)
     for test_class in test_classes:
         for sub_cls in plugin_base.generate_sub_tests(

diff --git a/test/dialect/test_suite.py b/test/dialect/test_suite.py
index e6d642ced3e8753315c0dccc8efd451729daa58a..3820a7721a755179bd7a1d9a239fa126e1bb613e 100644 (file)
--- a/test/dialect/test_suite.py
+++ b/test/dialect/test_suite.py
@@ -1,2 +1,3 @@
 from sqlalchemy.testing.suite import *
 
+