]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
bpo-44263: Fix _decimal and _testcapi GC protocol (GH-26464)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Mon, 31 May 2021 11:33:31 +0000 (04:33 -0700)
committerGitHub <noreply@github.com>
Mon, 31 May 2021 11:33:31 +0000 (04:33 -0700)
* _testcapi.heapgctype: implement a traverse function since the type
  is defined with Py_TPFLAGS_HAVE_GC.
* _decimal: PyDecSignalDictMixin_Type is no longer defined with
  Py_TPFLAGS_HAVE_GC since it has no traverse function.
(cherry picked from commit 142e5c5445c019542246d93fe2f9e195d3131686)

Co-authored-by: Victor Stinner <vstinner@python.org>
Modules/_decimal/_decimal.c
Modules/_testcapimodule.c

index fb4e020f1260e6ec9e17d77e5aa3317e08294a24..d80d7915507d9f46d1ed3daa686794d29605d66a 100644 (file)
@@ -696,8 +696,7 @@ static PyTypeObject PyDecSignalDictMixin_Type =
     PyObject_GenericGetAttr,                  /* tp_getattro */
     (setattrofunc) 0,                         /* tp_setattro */
     (PyBufferProcs *) 0,                      /* tp_as_buffer */
-    Py_TPFLAGS_DEFAULT|Py_TPFLAGS_BASETYPE|
-    Py_TPFLAGS_HAVE_GC,                       /* tp_flags */
+    Py_TPFLAGS_DEFAULT|Py_TPFLAGS_BASETYPE,   /* tp_flags */
     0,                                        /* tp_doc */
     0,                                        /* tp_traverse */
     0,                                        /* tp_clear */
index f4e04e77636cfbc7f995187f965a125542ce6571..4f6f193202b9b4195f25f66a91920f87638bb471 100644 (file)
@@ -6257,6 +6257,13 @@ heapctype_init(PyObject *self, PyObject *args, PyObject *kwargs)
     return 0;
 }
 
+static int
+heapgcctype_traverse(HeapCTypeObject *self, visitproc visit, void *arg)
+{
+    Py_VISIT(Py_TYPE(self));
+    return 0;
+}
+
 static void
 heapgcctype_dealloc(HeapCTypeObject *self)
 {
@@ -6270,6 +6277,7 @@ static PyType_Slot HeapGcCType_slots[] = {
     {Py_tp_init, heapctype_init},
     {Py_tp_members, heapctype_members},
     {Py_tp_dealloc, heapgcctype_dealloc},
+    {Py_tp_traverse, heapgcctype_traverse},
     {Py_tp_doc, (char*)heapgctype__doc__},
     {0, 0},
 };