]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
hwmon: (aspeed-g6-pwm-tach): remove redundant driver remove callback
authorBilly Tsai <billy_tsai@aspeedtech.com>
Mon, 9 Mar 2026 02:33:24 +0000 (10:33 +0800)
committerGuenter Roeck <linux@roeck-us.net>
Tue, 31 Mar 2026 02:45:06 +0000 (19:45 -0700)
Drops the remove callback as it only asserts reset and the probe already
registers a devres action (devm_add_action_or_reset()) to call
aspeed_pwm_tach_reset_assert().

Fixes: 7e1449cd15d1 ("hwmon: (aspeed-g6-pwm-tacho): Support for ASPEED g6 PWM/Fan tach")
Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
Link: https://lore.kernel.org/r/20260309-pwm_fixes-v2-1-ca9768e70470@aspeedtech.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/aspeed-g6-pwm-tach.c

index 44e1ecba205d7a0927ba16f1075a8411608e25a6..4f6e6d440dd405052ac056e6fd9cf8037746e62a 100644 (file)
@@ -517,13 +517,6 @@ static int aspeed_pwm_tach_probe(struct platform_device *pdev)
        return 0;
 }
 
-static void aspeed_pwm_tach_remove(struct platform_device *pdev)
-{
-       struct aspeed_pwm_tach_data *priv = platform_get_drvdata(pdev);
-
-       reset_control_assert(priv->reset);
-}
-
 static const struct of_device_id aspeed_pwm_tach_match[] = {
        {
                .compatible = "aspeed,ast2600-pwm-tach",
@@ -537,7 +530,6 @@ MODULE_DEVICE_TABLE(of, aspeed_pwm_tach_match);
 
 static struct platform_driver aspeed_pwm_tach_driver = {
        .probe = aspeed_pwm_tach_probe,
-       .remove = aspeed_pwm_tach_remove,
        .driver = {
                .name = "aspeed-g6-pwm-tach",
                .of_match_table = aspeed_pwm_tach_match,