s3/smb3: ensure file_set_dosmode is passed valid smb_fname->fsp

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>

diff --git a/source3/smbd/reply.c b/source3/smbd/reply.c
index 45a2a298f65c9f064d224ca68a5b85392f87c62d..5190e60b3f41be4e580e32fe95a607dd5fc549cd 100644 (file)
--- a/source3/smbd/reply.c
+++ b/source3/smbd/reply.c
@@ -7582,6 +7582,7 @@ NTSTATUS rename_internals_fsp(connection_struct *conn,
                status = NT_STATUS_NO_MEMORY;
                goto out;
        }
+       if (smb_fname_dst_in)
 
        /*
         * Check for special case with case preserving and not
@@ -7824,23 +7825,33 @@ NTSTATUS rename_internals_fsp(connection_struct *conn,
                    (lp_map_archive(SNUM(conn)) ||
                    lp_store_dos_attributes(SNUM(conn))))
                {
-                       /*
-                        * We must set the archive bit on the newly renamed
-                        * file.
-                        */
-                       ret = SMB_VFS_FSTAT(fsp, &smb_fname_dst->st);
-                       if (ret == 0) {
-                               uint32_t old_dosmode;
-
-                               fsp->fsp_name->st = smb_fname_dst->st;
-                               old_dosmode = fdos_mode(fsp);
-
-                               file_set_dosmode(conn,
-                                       smb_fname_dst,
-                                       old_dosmode | FILE_ATTRIBUTE_ARCHIVE,
-                                       NULL,
-                                       true);
+                       struct smb_filename *pathref = NULL;
+                       status = synthetic_pathref(ctx,
+                                               conn->cwd_fsp,
+                                               smb_fname_dst->base_name,
+                                               smb_fname_dst->stream_name,
+                                               NULL,
+                                               smb_fname_dst->twrp,
+                                               smb_fname_dst->flags,
+                                               &pathref);
+                       if (NT_STATUS_IS_OK(status)) {
+                               /*
+                                * We must set the archive bit on the newly renamed
+                                * file.
+                                */
+                               ret = SMB_VFS_FSTAT(fsp, &pathref->st);
+                               if (ret == 0) {
+                                       uint32_t old_dosmode;
+                                       fsp->fsp_name->st = pathref->st;
+                                       old_dosmode = fdos_mode(fsp);
+                                       file_set_dosmode(conn,
+                                                       pathref,
+                                                       old_dosmode | FILE_ATTRIBUTE_ARCHIVE,
+                                                       NULL,
+                                                       true);
+                               }
                        }
+                       TALLOC_FREE(pathref);
                }
 
                /*