]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
Fixes for 5.4
authorSasha Levin <sashal@kernel.org>
Sat, 9 Dec 2023 06:02:28 +0000 (01:02 -0500)
committerSasha Levin <sashal@kernel.org>
Sat, 9 Dec 2023 06:02:28 +0000 (01:02 -0500)
Signed-off-by: Sasha Levin <sashal@kernel.org>
queue-5.4/arm-dts-imx-make-gpt-node-name-generic.patch [new file with mode: 0644]
queue-5.4/arm-dts-imx7-declare-timers-compatible-with-fsl-imx6.patch [new file with mode: 0644]
queue-5.4/arm-imx-check-return-value-of-devm_kasprintf-in-imx_.patch [new file with mode: 0644]
queue-5.4/asoc-wm_adsp-fix-memleak-in-wm_adsp_buffer_populate.patch [new file with mode: 0644]
queue-5.4/hwmon-acpi_power_meter-fix-4.29-mw-bug.patch [new file with mode: 0644]
queue-5.4/rdma-bnxt_re-correct-module-description-string.patch [new file with mode: 0644]
queue-5.4/scsi-be2iscsi-fix-a-memleak-in-beiscsi_init_wrb_hand.patch [new file with mode: 0644]
queue-5.4/series
queue-5.4/tracing-fix-a-warning-when-allocating-buffered-event.patch [new file with mode: 0644]

diff --git a/queue-5.4/arm-dts-imx-make-gpt-node-name-generic.patch b/queue-5.4/arm-dts-imx-make-gpt-node-name-generic.patch
new file mode 100644 (file)
index 0000000..2bf506e
--- /dev/null
@@ -0,0 +1,127 @@
+From ea363269293cd4e72a3222b61688374bf828f011 Mon Sep 17 00:00:00 2001
+From: Sasha Levin <sashal@kernel.org>
+Date: Thu, 13 Feb 2020 10:52:56 +0800
+Subject: ARM: dts: imx: make gpt node name generic
+
+From: Anson Huang <Anson.Huang@nxp.com>
+
+[ Upstream commit 7c48b086965873c0aa93d99773cf64c033b76b2f ]
+
+Node name should be generic, use "timer" instead of "gpt" for gpt node.
+
+Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
+Signed-off-by: Shawn Guo <shawnguo@kernel.org>
+Stable-dep-of: 397caf68e2d3 ("ARM: dts: imx7: Declare timers compatible with fsl,imx6dl-gpt")
+Signed-off-by: Sasha Levin <sashal@kernel.org>
+---
+ arch/arm/boot/dts/imx6qdl.dtsi | 2 +-
+ arch/arm/boot/dts/imx6sl.dtsi  | 2 +-
+ arch/arm/boot/dts/imx6sx.dtsi  | 2 +-
+ arch/arm/boot/dts/imx6ul.dtsi  | 4 ++--
+ arch/arm/boot/dts/imx7s.dtsi   | 8 ++++----
+ 5 files changed, 9 insertions(+), 9 deletions(-)
+
+diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
+index 861392ff70861..0150b2d5c534f 100644
+--- a/arch/arm/boot/dts/imx6qdl.dtsi
++++ b/arch/arm/boot/dts/imx6qdl.dtsi
+@@ -578,7 +578,7 @@
+                               status = "disabled";
+                       };
+-                      gpt: gpt@2098000 {
++                      gpt: timer@2098000 {
+                               compatible = "fsl,imx6q-gpt", "fsl,imx31-gpt";
+                               reg = <0x02098000 0x4000>;
+                               interrupts = <0 55 IRQ_TYPE_LEVEL_HIGH>;
+diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi
+index 3cf1da06e7f04..fbbae0004e627 100644
+--- a/arch/arm/boot/dts/imx6sl.dtsi
++++ b/arch/arm/boot/dts/imx6sl.dtsi
+@@ -386,7 +386,7 @@
+                               clock-names = "ipg", "per";
+                       };
+-                      gpt: gpt@2098000 {
++                      gpt: timer@2098000 {
+                               compatible = "fsl,imx6sl-gpt";
+                               reg = <0x02098000 0x4000>;
+                               interrupts = <0 55 IRQ_TYPE_LEVEL_HIGH>;
+diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
+index 3dc1e97e145cd..1afeae14560ad 100644
+--- a/arch/arm/boot/dts/imx6sx.dtsi
++++ b/arch/arm/boot/dts/imx6sx.dtsi
+@@ -475,7 +475,7 @@
+                               status = "disabled";
+                       };
+-                      gpt: gpt@2098000 {
++                      gpt: timer@2098000 {
+                               compatible = "fsl,imx6sx-gpt", "fsl,imx6dl-gpt";
+                               reg = <0x02098000 0x4000>;
+                               interrupts = <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>;
+diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi
+index 5b677b66162ac..7037d2a45e60f 100644
+--- a/arch/arm/boot/dts/imx6ul.dtsi
++++ b/arch/arm/boot/dts/imx6ul.dtsi
+@@ -433,7 +433,7 @@
+                               status = "disabled";
+                       };
+-                      gpt1: gpt@2098000 {
++                      gpt1: timer@2098000 {
+                               compatible = "fsl,imx6ul-gpt", "fsl,imx6sx-gpt";
+                               reg = <0x02098000 0x4000>;
+                               interrupts = <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>;
+@@ -707,7 +707,7 @@
+                               reg = <0x020e4000 0x4000>;
+                       };
+-                      gpt2: gpt@20e8000 {
++                      gpt2: timer@20e8000 {
+                               compatible = "fsl,imx6ul-gpt", "fsl,imx6sx-gpt";
+                               reg = <0x020e8000 0x4000>;
+                               interrupts = <GIC_SPI 109 IRQ_TYPE_LEVEL_HIGH>;
+diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi
+index 791530124fb0a..f774759af1aa3 100644
+--- a/arch/arm/boot/dts/imx7s.dtsi
++++ b/arch/arm/boot/dts/imx7s.dtsi
+@@ -446,7 +446,7 @@
+                               fsl,input-sel = <&iomuxc>;
+                       };
+-                      gpt1: gpt@302d0000 {
++                      gpt1: timer@302d0000 {
+                               compatible = "fsl,imx7d-gpt", "fsl,imx6sx-gpt";
+                               reg = <0x302d0000 0x10000>;
+                               interrupts = <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>;
+@@ -455,7 +455,7 @@
+                               clock-names = "ipg", "per";
+                       };
+-                      gpt2: gpt@302e0000 {
++                      gpt2: timer@302e0000 {
+                               compatible = "fsl,imx7d-gpt", "fsl,imx6sx-gpt";
+                               reg = <0x302e0000 0x10000>;
+                               interrupts = <GIC_SPI 54 IRQ_TYPE_LEVEL_HIGH>;
+@@ -465,7 +465,7 @@
+                               status = "disabled";
+                       };
+-                      gpt3: gpt@302f0000 {
++                      gpt3: timer@302f0000 {
+                               compatible = "fsl,imx7d-gpt", "fsl,imx6sx-gpt";
+                               reg = <0x302f0000 0x10000>;
+                               interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>;
+@@ -475,7 +475,7 @@
+                               status = "disabled";
+                       };
+-                      gpt4: gpt@30300000 {
++                      gpt4: timer@30300000 {
+                               compatible = "fsl,imx7d-gpt", "fsl,imx6sx-gpt";
+                               reg = <0x30300000 0x10000>;
+                               interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;
+-- 
+2.42.0
+
diff --git a/queue-5.4/arm-dts-imx7-declare-timers-compatible-with-fsl-imx6.patch b/queue-5.4/arm-dts-imx7-declare-timers-compatible-with-fsl-imx6.patch
new file mode 100644 (file)
index 0000000..b7508de
--- /dev/null
@@ -0,0 +1,65 @@
+From f5390e4ecafa5ff7d771924c951b142e9c461973 Mon Sep 17 00:00:00 2001
+From: Sasha Levin <sashal@kernel.org>
+Date: Mon, 27 Nov 2023 17:05:01 +0100
+Subject: ARM: dts: imx7: Declare timers compatible with fsl,imx6dl-gpt
+
+From: Philipp Zabel <p.zabel@pengutronix.de>
+
+[ Upstream commit 397caf68e2d36532054cb14ae8995537f27f8b61 ]
+
+The timer nodes declare compatibility with "fsl,imx6sx-gpt", which
+itself is compatible with "fsl,imx6dl-gpt". Switch the fallback
+compatible from "fsl,imx6sx-gpt" to "fsl,imx6dl-gpt".
+
+Fixes: 949673450291 ("ARM: dts: add imx7d soc dtsi file")
+Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
+Signed-off-by: Roland Hieber <rhi@pengutronix.de>
+Signed-off-by: Shawn Guo <shawnguo@kernel.org>
+Signed-off-by: Sasha Levin <sashal@kernel.org>
+---
+ arch/arm/boot/dts/imx7s.dtsi | 8 ++++----
+ 1 file changed, 4 insertions(+), 4 deletions(-)
+
+diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi
+index f774759af1aa3..7ce541fcac767 100644
+--- a/arch/arm/boot/dts/imx7s.dtsi
++++ b/arch/arm/boot/dts/imx7s.dtsi
+@@ -447,7 +447,7 @@
+                       };
+                       gpt1: timer@302d0000 {
+-                              compatible = "fsl,imx7d-gpt", "fsl,imx6sx-gpt";
++                              compatible = "fsl,imx7d-gpt", "fsl,imx6dl-gpt";
+                               reg = <0x302d0000 0x10000>;
+                               interrupts = <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>;
+                               clocks = <&clks IMX7D_GPT1_ROOT_CLK>,
+@@ -456,7 +456,7 @@
+                       };
+                       gpt2: timer@302e0000 {
+-                              compatible = "fsl,imx7d-gpt", "fsl,imx6sx-gpt";
++                              compatible = "fsl,imx7d-gpt", "fsl,imx6dl-gpt";
+                               reg = <0x302e0000 0x10000>;
+                               interrupts = <GIC_SPI 54 IRQ_TYPE_LEVEL_HIGH>;
+                               clocks = <&clks IMX7D_GPT2_ROOT_CLK>,
+@@ -466,7 +466,7 @@
+                       };
+                       gpt3: timer@302f0000 {
+-                              compatible = "fsl,imx7d-gpt", "fsl,imx6sx-gpt";
++                              compatible = "fsl,imx7d-gpt", "fsl,imx6dl-gpt";
+                               reg = <0x302f0000 0x10000>;
+                               interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>;
+                               clocks = <&clks IMX7D_GPT3_ROOT_CLK>,
+@@ -476,7 +476,7 @@
+                       };
+                       gpt4: timer@30300000 {
+-                              compatible = "fsl,imx7d-gpt", "fsl,imx6sx-gpt";
++                              compatible = "fsl,imx7d-gpt", "fsl,imx6dl-gpt";
+                               reg = <0x30300000 0x10000>;
+                               interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;
+                               clocks = <&clks IMX7D_GPT4_ROOT_CLK>,
+-- 
+2.42.0
+
diff --git a/queue-5.4/arm-imx-check-return-value-of-devm_kasprintf-in-imx_.patch b/queue-5.4/arm-imx-check-return-value-of-devm_kasprintf-in-imx_.patch
new file mode 100644 (file)
index 0000000..045f810
--- /dev/null
@@ -0,0 +1,55 @@
+From 86e1ff69fc8d7a7033b3d7a5b27f8b4c6d3227de Mon Sep 17 00:00:00 2001
+From: Sasha Levin <sashal@kernel.org>
+Date: Wed, 22 Nov 2023 14:46:36 +0800
+Subject: ARM: imx: Check return value of devm_kasprintf in imx_mmdc_perf_init
+
+From: Kunwu Chan <chentao@kylinos.cn>
+
+[ Upstream commit 1c2b1049af3f86545fcc5fae0fc725fb64b3a09e ]
+
+devm_kasprintf() returns a pointer to dynamically allocated memory
+which can be NULL upon failure. Ensure the allocation was successful
+by checking the pointer validity.
+
+Release the id allocated in 'mmdc_pmu_init' when 'devm_kasprintf'
+return NULL
+
+Suggested-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
+Fixes: e76bdfd7403a ("ARM: imx: Added perf functionality to mmdc driver")
+Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
+Signed-off-by: Shawn Guo <shawnguo@kernel.org>
+Signed-off-by: Sasha Levin <sashal@kernel.org>
+---
+ arch/arm/mach-imx/mmdc.c | 7 ++++++-
+ 1 file changed, 6 insertions(+), 1 deletion(-)
+
+diff --git a/arch/arm/mach-imx/mmdc.c b/arch/arm/mach-imx/mmdc.c
+index b9efe9da06e0b..3d76e8c28c51d 100644
+--- a/arch/arm/mach-imx/mmdc.c
++++ b/arch/arm/mach-imx/mmdc.c
+@@ -502,6 +502,10 @@ static int imx_mmdc_perf_init(struct platform_device *pdev, void __iomem *mmdc_b
+       name = devm_kasprintf(&pdev->dev,
+                               GFP_KERNEL, "mmdc%d", ret);
++      if (!name) {
++              ret = -ENOMEM;
++              goto pmu_release_id;
++      }
+       pmu_mmdc->mmdc_ipg_clk = mmdc_ipg_clk;
+       pmu_mmdc->devtype_data = (struct fsl_mmdc_devtype_data *)of_id->data;
+@@ -524,9 +528,10 @@ static int imx_mmdc_perf_init(struct platform_device *pdev, void __iomem *mmdc_b
+ pmu_register_err:
+       pr_warn("MMDC Perf PMU failed (%d), disabled\n", ret);
+-      ida_simple_remove(&mmdc_ida, pmu_mmdc->id);
+       cpuhp_state_remove_instance_nocalls(cpuhp_mmdc_state, &pmu_mmdc->node);
+       hrtimer_cancel(&pmu_mmdc->hrtimer);
++pmu_release_id:
++      ida_simple_remove(&mmdc_ida, pmu_mmdc->id);
+ pmu_free:
+       kfree(pmu_mmdc);
+       return ret;
+-- 
+2.42.0
+
diff --git a/queue-5.4/asoc-wm_adsp-fix-memleak-in-wm_adsp_buffer_populate.patch b/queue-5.4/asoc-wm_adsp-fix-memleak-in-wm_adsp_buffer_populate.patch
new file mode 100644 (file)
index 0000000..e939a01
--- /dev/null
@@ -0,0 +1,57 @@
+From 2cb2f990a5b9428dc4d81ec676a03a1a66eca5ad Mon Sep 17 00:00:00 2001
+From: Sasha Levin <sashal@kernel.org>
+Date: Mon, 4 Dec 2023 15:41:56 +0800
+Subject: ASoC: wm_adsp: fix memleak in wm_adsp_buffer_populate
+
+From: Dinghao Liu <dinghao.liu@zju.edu.cn>
+
+[ Upstream commit 29046a78a3c0a1f8fa0427f164caa222f003cf5b ]
+
+When wm_adsp_buffer_read() fails, we should free buf->regions.
+Otherwise, the callers of wm_adsp_buffer_populate() will
+directly free buf on failure, which makes buf->regions a leaked
+memory.
+
+Fixes: a792af69b08f ("ASoC: wm_adsp: Refactor compress stream initialisation")
+Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
+Reviewed-by: Richard Fitzgerald <rf@opensource.cirrus.com>
+Link: https://lore.kernel.org/r/20231204074158.12026-1-dinghao.liu@zju.edu.cn
+Signed-off-by: Mark Brown <broonie@kernel.org>
+Signed-off-by: Sasha Levin <sashal@kernel.org>
+---
+ sound/soc/codecs/wm_adsp.c | 8 ++++++--
+ 1 file changed, 6 insertions(+), 2 deletions(-)
+
+diff --git a/sound/soc/codecs/wm_adsp.c b/sound/soc/codecs/wm_adsp.c
+index aedfa6b2895bd..8df5f3bc6e974 100644
+--- a/sound/soc/codecs/wm_adsp.c
++++ b/sound/soc/codecs/wm_adsp.c
+@@ -3649,12 +3649,12 @@ static int wm_adsp_buffer_populate(struct wm_adsp_compr_buf *buf)
+               ret = wm_adsp_buffer_read(buf, caps->region_defs[i].base_offset,
+                                         &region->base_addr);
+               if (ret < 0)
+-                      return ret;
++                      goto err;
+               ret = wm_adsp_buffer_read(buf, caps->region_defs[i].size_offset,
+                                         &offset);
+               if (ret < 0)
+-                      return ret;
++                      goto err;
+               region->cumulative_size = offset;
+@@ -3665,6 +3665,10 @@ static int wm_adsp_buffer_populate(struct wm_adsp_compr_buf *buf)
+       }
+       return 0;
++
++err:
++      kfree(buf->regions);
++      return ret;
+ }
+ static void wm_adsp_buffer_clear(struct wm_adsp_compr_buf *buf)
+-- 
+2.42.0
+
diff --git a/queue-5.4/hwmon-acpi_power_meter-fix-4.29-mw-bug.patch b/queue-5.4/hwmon-acpi_power_meter-fix-4.29-mw-bug.patch
new file mode 100644 (file)
index 0000000..1031ff4
--- /dev/null
@@ -0,0 +1,55 @@
+From 6f211ba7a6ae8bb122aee3596444d4140c484f86 Mon Sep 17 00:00:00 2001
+From: Sasha Levin <sashal@kernel.org>
+Date: Fri, 24 Nov 2023 19:27:47 +0100
+Subject: hwmon: (acpi_power_meter) Fix 4.29 MW bug
+
+From: Armin Wolf <W_Armin@gmx.de>
+
+[ Upstream commit 1fefca6c57fb928d2131ff365270cbf863d89c88 ]
+
+The ACPI specification says:
+
+"If an error occurs while obtaining the meter reading or if the value
+is not available then an Integer with all bits set is returned"
+
+Since the "integer" is 32 bits in case of the ACPI power meter,
+userspace will get a power reading of 2^32 * 1000 miliwatts (~4.29 MW)
+in case of such an error. This was discovered due to a lm_sensors
+bugreport (https://github.com/lm-sensors/lm-sensors/issues/460).
+Fix this by returning -ENODATA instead.
+
+Tested-by: <urbinek@gmail.com>
+Fixes: de584afa5e18 ("hwmon driver for ACPI 4.0 power meters")
+Signed-off-by: Armin Wolf <W_Armin@gmx.de>
+Link: https://lore.kernel.org/r/20231124182747.13956-1-W_Armin@gmx.de
+Signed-off-by: Guenter Roeck <linux@roeck-us.net>
+Signed-off-by: Sasha Levin <sashal@kernel.org>
+---
+ drivers/hwmon/acpi_power_meter.c | 4 ++++
+ 1 file changed, 4 insertions(+)
+
+diff --git a/drivers/hwmon/acpi_power_meter.c b/drivers/hwmon/acpi_power_meter.c
+index 740ac0a1b7265..549c8f30accea 100644
+--- a/drivers/hwmon/acpi_power_meter.c
++++ b/drivers/hwmon/acpi_power_meter.c
+@@ -32,6 +32,7 @@ ACPI_MODULE_NAME(ACPI_POWER_METER_NAME);
+ #define POWER_METER_CAN_NOTIFY        (1 << 3)
+ #define POWER_METER_IS_BATTERY        (1 << 8)
+ #define UNKNOWN_HYSTERESIS    0xFFFFFFFF
++#define UNKNOWN_POWER         0xFFFFFFFF
+ #define METER_NOTIFY_CONFIG   0x80
+ #define METER_NOTIFY_TRIP     0x81
+@@ -343,6 +344,9 @@ static ssize_t show_power(struct device *dev,
+       update_meter(resource);
+       mutex_unlock(&resource->lock);
++      if (resource->power == UNKNOWN_POWER)
++              return -ENODATA;
++
+       return sprintf(buf, "%llu\n", resource->power * 1000);
+ }
+-- 
+2.42.0
+
diff --git a/queue-5.4/rdma-bnxt_re-correct-module-description-string.patch b/queue-5.4/rdma-bnxt_re-correct-module-description-string.patch
new file mode 100644 (file)
index 0000000..cf192d6
--- /dev/null
@@ -0,0 +1,38 @@
+From df469c2f58f23158ed234e772e0a2e142c139d3a Mon Sep 17 00:00:00 2001
+From: Sasha Levin <sashal@kernel.org>
+Date: Tue, 21 Nov 2023 00:29:47 -0800
+Subject: RDMA/bnxt_re: Correct module description string
+
+From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
+
+[ Upstream commit 422b19f7f006e813ee0865aadce6a62b3c263c42 ]
+
+The word "Driver" is repeated twice in the "modinfo bnxt_re"
+output description. Fix it.
+
+Fixes: 1ac5a4047975 ("RDMA/bnxt_re: Add bnxt_re RoCE driver")
+Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
+Signed-off-by: Selvin Xavier <selvin.xavier@broadcom.com>
+Link: https://lore.kernel.org/r/1700555387-6277-1-git-send-email-selvin.xavier@broadcom.com
+Signed-off-by: Leon Romanovsky <leon@kernel.org>
+Signed-off-by: Sasha Levin <sashal@kernel.org>
+---
+ drivers/infiniband/hw/bnxt_re/main.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/drivers/infiniband/hw/bnxt_re/main.c b/drivers/infiniband/hw/bnxt_re/main.c
+index a40bc23196bf7..34d1c42646029 100644
+--- a/drivers/infiniband/hw/bnxt_re/main.c
++++ b/drivers/infiniband/hw/bnxt_re/main.c
+@@ -70,7 +70,7 @@ static char version[] =
+               BNXT_RE_DESC "\n";
+ MODULE_AUTHOR("Eddie Wai <eddie.wai@broadcom.com>");
+-MODULE_DESCRIPTION(BNXT_RE_DESC " Driver");
++MODULE_DESCRIPTION(BNXT_RE_DESC);
+ MODULE_LICENSE("Dual BSD/GPL");
+ /* globals */
+-- 
+2.42.0
+
diff --git a/queue-5.4/scsi-be2iscsi-fix-a-memleak-in-beiscsi_init_wrb_hand.patch b/queue-5.4/scsi-be2iscsi-fix-a-memleak-in-beiscsi_init_wrb_hand.patch
new file mode 100644 (file)
index 0000000..b652bf4
--- /dev/null
@@ -0,0 +1,38 @@
+From 710cb01de32198e94b3365bab1748d1080e5b048 Mon Sep 17 00:00:00 2001
+From: Sasha Levin <sashal@kernel.org>
+Date: Thu, 23 Nov 2023 16:19:41 +0800
+Subject: scsi: be2iscsi: Fix a memleak in beiscsi_init_wrb_handle()
+
+From: Dinghao Liu <dinghao.liu@zju.edu.cn>
+
+[ Upstream commit 235f2b548d7f4ac5931d834f05d3f7f5166a2e72 ]
+
+When an error occurs in the for loop of beiscsi_init_wrb_handle(), we
+should free phwi_ctxt->be_wrbq before returning an error code to prevent
+potential memleak.
+
+Fixes: a7909b396ba7 ("[SCSI] be2iscsi: Fix dynamic CID allocation Mechanism in driver")
+Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
+Link: https://lore.kernel.org/r/20231123081941.24854-1-dinghao.liu@zju.edu.cn
+Reviewed-by: Mike Christie <michael.christie@oracle.com>
+Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
+Signed-off-by: Sasha Levin <sashal@kernel.org>
+---
+ drivers/scsi/be2iscsi/be_main.c | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
+index 53b33f146f825..d34c881c3f8ae 100644
+--- a/drivers/scsi/be2iscsi/be_main.c
++++ b/drivers/scsi/be2iscsi/be_main.c
+@@ -2694,6 +2694,7 @@ static int beiscsi_init_wrb_handle(struct beiscsi_hba *phba)
+               kfree(pwrb_context->pwrb_handle_base);
+               kfree(pwrb_context->pwrb_handle_basestd);
+       }
++      kfree(phwi_ctxt->be_wrbq);
+       return -ENOMEM;
+ }
+-- 
+2.42.0
+
index 3b048e56bc611664108e403c0eec80e5c734fbf2..0c9dedd194c1d277ea20719e39b000638e3cb8d2 100644 (file)
@@ -24,3 +24,11 @@ net-hns-fix-fake-link-up-on-xge-port.patch
 netfilter-xt_owner-fix-for-unsafe-access-of-sk-sk_so.patch
 tcp-do-not-accept-ack-of-bytes-we-never-sent.patch
 bpf-sockmap-updating-the-sg-structure-should-also-up.patch
+rdma-bnxt_re-correct-module-description-string.patch
+hwmon-acpi_power_meter-fix-4.29-mw-bug.patch
+asoc-wm_adsp-fix-memleak-in-wm_adsp_buffer_populate.patch
+tracing-fix-a-warning-when-allocating-buffered-event.patch
+scsi-be2iscsi-fix-a-memleak-in-beiscsi_init_wrb_hand.patch
+arm-imx-check-return-value-of-devm_kasprintf-in-imx_.patch
+arm-dts-imx-make-gpt-node-name-generic.patch
+arm-dts-imx7-declare-timers-compatible-with-fsl-imx6.patch
diff --git a/queue-5.4/tracing-fix-a-warning-when-allocating-buffered-event.patch b/queue-5.4/tracing-fix-a-warning-when-allocating-buffered-event.patch
new file mode 100644 (file)
index 0000000..ea57265
--- /dev/null
@@ -0,0 +1,83 @@
+From 1e58886f95f59accd4ec5aad10ec9a15a67d4e48 Mon Sep 17 00:00:00 2001
+From: Sasha Levin <sashal@kernel.org>
+Date: Tue, 5 Dec 2023 17:17:35 +0100
+Subject: tracing: Fix a warning when allocating buffered events fails
+
+From: Petr Pavlu <petr.pavlu@suse.com>
+
+[ Upstream commit 34209fe83ef8404353f91ab4ea4035dbc9922d04 ]
+
+Function trace_buffered_event_disable() produces an unexpected warning
+when the previous call to trace_buffered_event_enable() fails to
+allocate pages for buffered events.
+
+The situation can occur as follows:
+
+* The counter trace_buffered_event_ref is at 0.
+
+* The soft mode gets enabled for some event and
+  trace_buffered_event_enable() is called. The function increments
+  trace_buffered_event_ref to 1 and starts allocating event pages.
+
+* The allocation fails for some page and trace_buffered_event_disable()
+  is called for cleanup.
+
+* Function trace_buffered_event_disable() decrements
+  trace_buffered_event_ref back to 0, recognizes that it was the last
+  use of buffered events and frees all allocated pages.
+
+* The control goes back to trace_buffered_event_enable() which returns.
+  The caller of trace_buffered_event_enable() has no information that
+  the function actually failed.
+
+* Some time later, the soft mode is disabled for the same event.
+  Function trace_buffered_event_disable() is called. It warns on
+  "WARN_ON_ONCE(!trace_buffered_event_ref)" and returns.
+
+Buffered events are just an optimization and can handle failures. Make
+trace_buffered_event_enable() exit on the first failure and left any
+cleanup later to when trace_buffered_event_disable() is called.
+
+Link: https://lore.kernel.org/all/20231127151248.7232-2-petr.pavlu@suse.com/
+Link: https://lkml.kernel.org/r/20231205161736.19663-3-petr.pavlu@suse.com
+
+Fixes: 0fc1b09ff1ff ("tracing: Use temp buffer when filtering events")
+Signed-off-by: Petr Pavlu <petr.pavlu@suse.com>
+Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
+Signed-off-by: Sasha Levin <sashal@kernel.org>
+---
+ kernel/trace/trace.c | 11 +++++------
+ 1 file changed, 5 insertions(+), 6 deletions(-)
+
+diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
+index a15dffe60722f..b8030f1e577bb 100644
+--- a/kernel/trace/trace.c
++++ b/kernel/trace/trace.c
+@@ -2438,8 +2438,11 @@ void trace_buffered_event_enable(void)
+       for_each_tracing_cpu(cpu) {
+               page = alloc_pages_node(cpu_to_node(cpu),
+                                       GFP_KERNEL | __GFP_NORETRY, 0);
+-              if (!page)
+-                      goto failed;
++              /* This is just an optimization and can handle failures */
++              if (!page) {
++                      pr_err("Failed to allocate event buffer\n");
++                      break;
++              }
+               event = page_address(page);
+               memset(event, 0, sizeof(*event));
+@@ -2453,10 +2456,6 @@ void trace_buffered_event_enable(void)
+                       WARN_ON_ONCE(1);
+               preempt_enable();
+       }
+-
+-      return;
+- failed:
+-      trace_buffered_event_disable();
+ }
+ static void enable_trace_buffered_event(void *data)
+-- 
+2.42.0
+