]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
virt-admin: Fix segfault when libvirtd dies
authorAdam Julis <ajulis@redhat.com>
Tue, 19 Mar 2024 11:02:51 +0000 (12:02 +0100)
committerJán Tomko <jtomko@redhat.com>
Tue, 19 Mar 2024 15:34:04 +0000 (16:34 +0100)
vshAdmCatchDisconnect requires non-NULL structure vshControl for
getting connection name (stored at opaque), but
virAdmConnectRegisterCloseCallback at vshAdmConnect called it
with NULL.

Signed-off-by: Adam Julis <ajulis@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Signed-off-by: Ján Tomko <jtomko@redhat.com>
tools/virt-admin.c

index 37bc6fe4f091e648823f588ca00f05a9083313c0..0766032e4ab7e085ac28d8c01c598ef5fe86ba94 100644 (file)
@@ -112,7 +112,7 @@ vshAdmConnect(vshControl *ctl, unsigned int flags)
         return -1;
     } else {
         if (virAdmConnectRegisterCloseCallback(priv->conn, vshAdmCatchDisconnect,
-                                               NULL, NULL) < 0)
+                                               ctl, NULL) < 0)
             vshError(ctl, "%s", _("Unable to register disconnect callback"));
 
         if (priv->wantReconnect)