]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
usb: gadget: midi2: Fix missing UMP group attributes initialization
authorTakashi Iwai <tiwai@suse.de>
Thu, 4 Sep 2025 15:39:24 +0000 (17:39 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 19 Sep 2025 14:35:51 +0000 (16:35 +0200)
commit 21d8525d2e061cde034277d518411b02eac764e2 upstream.

The gadget card driver forgot to call snd_ump_update_group_attrs()
after adding FBs, and this leaves the UMP group attributes
uninitialized.  As a result, -ENODEV error is returned at opening a
legacy rawmidi device as an inactive group.

This patch adds the missing call to address the behavior above.

Fixes: 8b645922b223 ("usb: gadget: Add support for USB MIDI 2.0 function driver")
Cc: stable <stable@kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20250904153932.13589-1-tiwai@suse.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/gadget/function/f_midi2.c

index 0c45936f51b3d7762480d3f1c74f0114abc43804..1d11ca313fb9ff317aba6fabc81667feb2109046 100644 (file)
@@ -1601,6 +1601,7 @@ static int f_midi2_create_card(struct f_midi2 *midi2)
                        strscpy(fb->info.name, ump_fb_name(b),
                                sizeof(fb->info.name));
                }
+               snd_ump_update_group_attrs(ump);
        }
 
        for (i = 0; i < midi2->num_eps; i++) {