]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3:script: Fix shellcheck errors in test_smbclient_s3.sh
authorAndreas Schneider <asn@samba.org>
Fri, 4 Mar 2022 11:08:28 +0000 (12:08 +0100)
committerPavel Filipensky <pfilipensky@samba.org>
Mon, 22 Aug 2022 14:20:36 +0000 (14:20 +0000)
source3/script/tests/test_smbclient_s3.sh:270:5: error: Couldn't parse
this test expression. Fix to allow more checks. [SC1073]

source3/script/tests/test_smbclient_s3.sh:270:11: error: Expected test
to end here (don't wrap commands in []/[[]]). Fix any mentioned problems
and try again. [SC1072]

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Pavel Filipenský <pfilipensky@samba.org>
source3/script/tests/test_smbclient_s3.sh

index 33737b22273b415a6486d55a83cd7fe0a86e6f5e..fed1723a5318e9dbc9b8728d51a244cac0ee5ac7 100755 (executable)
@@ -267,7 +267,7 @@ EOF
                return 1
        fi
 
-       if [ cmp $PREFIX/message_out.$$ $tmpfile != 0 ]; then
+       if cmp $PREFIX/message_out.$$ $tmpfile; then
                echo "failed comparison of message from $SERVER"
                return 1
        fi