lirc: rc_dev_get_from_fd(): fix file leak

[ Upstream commit bba1f6758a9ec90c1adac5dcf78f8a15f1bad65b ]

missing fdput() on a failure exit

Fixes: 6a9d552483d50 "media: rc: bpf attach/detach requires write permission" # v6.9
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/media/rc/lirc_dev.c b/drivers/media/rc/lirc_dev.c
index 52aea41677183797d06ce632d28356fed59c870a..717c441b4a86541f0471084aafd6e9bd38fdf7ee 100644 (file)
--- a/drivers/media/rc/lirc_dev.c
+++ b/drivers/media/rc/lirc_dev.c
@@ -828,8 +828,10 @@ struct rc_dev *rc_dev_get_from_fd(int fd, bool write)
                return ERR_PTR(-EINVAL);
        }
 
-       if (write && !(f.file->f_mode & FMODE_WRITE))
+       if (write && !(f.file->f_mode & FMODE_WRITE)) {
+               fdput(f);
                return ERR_PTR(-EPERM);
+       }
 
        fh = f.file->private_data;
        dev = fh->rc;