Coverity 400477: pcre_get_substring retval

Add missing return code check to pcre_get_substring call.

diff --git a/src/detect-parse.c b/src/detect-parse.c
index ff985b12e4dd9c2907eee9ae1d1c5c1122a588d5..85c7fbc6e5877870c4a6429e64571e2820c28e83 100644 (file)
--- a/src/detect-parse.c
+++ b/src/detect-parse.c
@@ -768,7 +768,8 @@ static int SigParseBasics(Signature *s, char *sigstr, char ***result, uint8_t ad
     }
 
     for (i = 1; i <= ret - 1; i++) {
-        pcre_get_substring(sigstr, ov, MAX_SUBSTRINGS, i, &arr[i - 1]);
+        if (pcre_get_substring(sigstr, ov, MAX_SUBSTRINGS, i, &arr[i - 1]) < 0)
+            goto error;
         //printf("SigParseBasics: arr[%" PRId32 "] = \"%s\"\n", i-1, arr[i-1]);
     }
     arr[i - 1] = NULL;