]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
rust: cpufreq: suppress clippy::double_parens in Policy doctest
authorJohn Hubbard <jhubbard@nvidia.com>
Thu, 12 Mar 2026 04:19:34 +0000 (21:19 -0700)
committerMiguel Ojeda <ojeda@kernel.org>
Thu, 12 Mar 2026 10:01:23 +0000 (11:01 +0100)
The kernel fmt! proc macro wraps each format argument as &(arg). Passing a
tuple such as (a, b) produces &((a, b)) after expansion. Clippy flags that
as double_parens, but it is a false positive fixed in Clippy 1.92 [1] [2].

Suppress the warning on the affected doctest function with a reason
attribute so it can be removed once the minimum toolchain moves past 1.92.

[ We may end up deciding to support per-version Clippy lints, in which
  case we will need [3].

  In the future, if [4] gets fixed, we may be able to use
  `Delimiter::None` as Gary suggested in [5].

Link: https://lore.kernel.org/rust-for-linux/20260307170929.153892-1-ojeda@kernel.org/
Link: https://github.com/rust-lang/rust/issues/67062
Link: https://lore.kernel.org/rust-for-linux/DGUA5GY2DGYN.3PG0FKLG7GFN1@garyguo.net/
    - Miguel ]

Link: https://github.com/rust-lang/rust-clippy/issues/15852
Link: https://github.com/rust-lang/rust-clippy/pull/15939
Suggested-by: Gary Guo <gary@garyguo.net>
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Link: https://patch.msgid.link/20260312041934.362840-2-jhubbard@nvidia.com
[ Reworded to replace GitHub-like short link with full URLs in Link tags.
  Reworded reason string to match the style of a couple others we have
  elsewhere. - Miguel ]
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
rust/kernel/cpufreq.rs

index 76faa1ac85017aab29696de65d6ad8504a10ba68..f5adee48d40cb83d9e326f593db88f150bb1a79c 100644 (file)
@@ -401,6 +401,7 @@ impl TableBuilder {
 /// ```
 /// use kernel::cpufreq::{DEFAULT_TRANSITION_LATENCY_NS, Policy};
 ///
+/// #[allow(clippy::double_parens, reason = "False positive before 1.92.0")]
 /// fn update_policy(policy: &mut Policy) {
 ///     policy
 ///         .set_dvfs_possible_from_any_cpu(true)