]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
serial: ar933x: Deassert Transmit Enable on ->rs485_config()
authorLukas Wunner <lukas@wunner.de>
Sun, 11 Sep 2022 09:12:15 +0000 (11:12 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 21 Oct 2022 10:37:43 +0000 (12:37 +0200)
commit 3a939433ddc1bab98be028903aaa286e5e7461d7 upstream.

The ar933x_uart driver neglects to deassert Transmit Enable when
->rs485_config() is invoked.  Fix it.

Fixes: 9be1064fe524 ("serial: ar933x_uart: add RS485 support")
Cc: stable@vger.kernel.org # v5.7+
Cc: Daniel Golle <daniel@makrotopia.org>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Lukas Wunner <lukas@wunner.de>
Link: https://lore.kernel.org/r/5b36af26e57553f084334666e7d24c7fd131a01e.1662887231.git.lukas@wunner.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/ar933x_uart.c

index 32caeac1298587fe52c7d4884e906163c560e8a6..a4ce0b63aabdf706f377f60e2e8a2f71dd74fe81 100644 (file)
@@ -583,6 +583,13 @@ static const struct uart_ops ar933x_uart_ops = {
 static int ar933x_config_rs485(struct uart_port *port, struct ktermios *termios,
                                struct serial_rs485 *rs485conf)
 {
+       struct ar933x_uart_port *up =
+                       container_of(port, struct ar933x_uart_port, port);
+
+       if (port->rs485.flags & SER_RS485_ENABLED)
+               gpiod_set_value(up->rts_gpiod,
+                       !!(rs485conf->flags & SER_RS485_RTS_AFTER_SEND));
+
        return 0;
 }