bpo-36176: Fix IDLE autocomplete & calltip popup colors. (#12262)

Prevent conflicts with Linux dark themes
(and slightly darken calltip background).

diff --git a/Lib/idlelib/NEWS.txt b/Lib/idlelib/NEWS.txt
index 58050f6ce965002a617745324c87b161513ff40d..c771dd0d41eb3a1bb633734754c2eb934e03e91f 100644 (file)
--- a/Lib/idlelib/NEWS.txt
+++ b/Lib/idlelib/NEWS.txt
@@ -3,7 +3,11 @@ Released on 2019-10-20?
 ======================================
 
 
-bpl-36152: Remove colorizer.ColorDelegator.close_when_done and the
+bpo-36176: Fix IDLE autocomplete & calltip popup colors.
+Prevent conflicts with Linux dark themes
+(and slightly darken calltip background).
+
+bpo-36152: Remove colorizer.ColorDelegator.close_when_done and the
 corresponding argument of .close().  In IDLE, both have always been
 None or False since 2007.
 

diff --git a/Lib/idlelib/autocomplete_w.py b/Lib/idlelib/autocomplete_w.py
index 7994bc0db170120fb8d6662172f40fc38b7082f5..c249625277369f86bfbb93513edb4315aaac67ec 100644 (file)
--- a/Lib/idlelib/autocomplete_w.py
+++ b/Lib/idlelib/autocomplete_w.py
@@ -189,7 +189,7 @@ class AutoCompleteWindow:
             pass
         self.scrollbar = scrollbar = Scrollbar(acw, orient=VERTICAL)
         self.listbox = listbox = Listbox(acw, yscrollcommand=scrollbar.set,
-                                         exportselection=False, bg="white")
+                                         exportselection=False)
         for item in self.completions:
             listbox.insert(END, item)
         self.origselforeground = listbox.cget("selectforeground")

diff --git a/Lib/idlelib/calltip_w.py b/Lib/idlelib/calltip_w.py
index 7553dfefc55c0bd8a52a0525a752893bf390e020..1e0404aa49f56287462d48400ecc76c1eaa57262 100644 (file)
--- a/Lib/idlelib/calltip_w.py
+++ b/Lib/idlelib/calltip_w.py
@@ -80,7 +80,8 @@ class CalltipWindow(TooltipBase):
     def showcontents(self):
         """Create the call-tip widget."""
         self.label = Label(self.tipwindow, text=self.text, justify=LEFT,
-                           background="#ffffe0", relief=SOLID, borderwidth=1,
+                           background="#ffffd0", foreground="black",
+                           relief=SOLID, borderwidth=1,
                            font=self.anchor_widget['font'])
         self.label.pack()
 

diff --git a/Misc/NEWS.d/next/IDLE/2019-03-10-00-07-46.bpo-36176.jk_vv6.rst b/Misc/NEWS.d/next/IDLE/2019-03-10-00-07-46.bpo-36176.jk_vv6.rst
new file mode 100644 (file)
index 0000000..5998c6f
--- /dev/null
+++ b/Misc/NEWS.d/next/IDLE/2019-03-10-00-07-46.bpo-36176.jk_vv6.rst
@@ -0,0 +1,2 @@
+Fix IDLE autocomplete & calltip popup colors. Prevent conflicts with Linux
+dark themes (and slightly darken calltip background).