]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
USB: adutux: NULL dereferences on disconnect
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 26 Nov 2014 14:06:49 +0000 (17:06 +0300)
committerLuis Henriques <luis.henriques@canonical.com>
Wed, 4 Feb 2015 10:58:29 +0000 (10:58 +0000)
commit fc625960edecfb57e62c2975d1f155155e28e6ba upstream.

Both "dev->udev" and "interface->dev" are NULL.  These printks are not
very interesting so I just deleted them.

Fixes: 03270634e242 ('USB: Add ADU support for Ontrak ADU devices')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
drivers/usb/misc/adutux.c

index 493c7f268b6f0965e9cb9a819a2588de4379941d..3071c0ef909bf0cd828feff797d332e4e33899be 100644 (file)
@@ -814,15 +814,10 @@ static void adu_disconnect(struct usb_interface *interface)
        usb_set_intfdata(interface, NULL);
 
        /* if the device is not opened, then we clean up right now */
-       dev_dbg(&dev->udev->dev, "%s : open count %d\n",
-               __func__, dev->open_count);
        if (!dev->open_count)
                adu_delete(dev);
 
        mutex_unlock(&adutux_mutex);
-
-       dev_info(&interface->dev, "ADU device adutux%d now disconnected\n",
-                (minor - ADU_MINOR_BASE));
 }
 
 /* usb specific object needed to register this driver with the usb subsystem */