]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
gpio: cgbc: normalize return value of gpio_get
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Wed, 18 Feb 2026 19:06:51 +0000 (11:06 -0800)
committerBartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Mon, 23 Feb 2026 09:41:42 +0000 (10:41 +0100)
The GPIO get callback is expected to return 0 or 1 (or a negative error
code). Ensure that the value returned by cgbc_gpio_get() is normalized
to the [0, 1] range.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Link: https://patch.msgid.link/20260218190657.2974723-2-dmitry.torokhov@gmail.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
drivers/gpio/gpio-cgbc.c

index 0efa1b61001ad5e9695f5ebb80e10f62a0809b2b..84b5ed3c6e22bbfd4c37b6fcaca2b7cfa5b016d5 100644 (file)
@@ -47,8 +47,8 @@ static int cgbc_gpio_get(struct gpio_chip *chip, unsigned int offset)
 
        if (ret)
                return ret;
-       else
-               return (int)(val & (u8)BIT(offset));
+
+       return !!(val & BIT(offset));
 }
 
 static int __cgbc_gpio_set(struct gpio_chip *chip, unsigned int offset,