]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
test-fs-util: re-order test_readlink_and_make_absolute and test_get_files_in_director...
authorMike Gilbert <floppymaster@gmail.com>
Wed, 5 Jul 2017 03:22:47 +0000 (23:22 -0400)
committerZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Wed, 5 Jul 2017 03:22:47 +0000 (23:22 -0400)
test_readlink_and_make_absolute switches to a temp directory, and then
removes it.

test_get_files_in_directory calls opendir(".") from a directory that has
been removed from the filesystem.

This call sequence triggers a bug in Gentoo's sandbox library. This
library attempts to resolve the "." to an absolute path, and aborts when
it ultimately fails to do so.

Re-ordering the calls works around the issue until the sandbox library
can be fixed to more gracefully deal with this.

Bug: https://bugs.gentoo.org/590084

src/test/test-fs-util.c

index e774f567e0307f8881fcd11bde724242144a9d4c..9e964a8bbb3c289f2991009a3e3731918ba7b6a2 100644 (file)
@@ -317,8 +317,8 @@ static void test_dot_or_dot_dot(void) {
 
 int main(int argc, char *argv[]) {
         test_unlink_noerrno();
-        test_readlink_and_make_absolute();
         test_get_files_in_directory();
+        test_readlink_and_make_absolute();
         test_var_tmp();
         test_chase_symlinks();
         test_dot_or_dot_dot();