]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
closes bpo-34471: _datetime: Add missing NULL check to tzinfo_from_isoformat_results...
authorAlexey Izbyshev <izbyshev@ispras.ru>
Fri, 24 Aug 2018 15:53:16 +0000 (18:53 +0300)
committerBenjamin Peterson <benjamin@python.org>
Fri, 24 Aug 2018 15:53:16 +0000 (08:53 -0700)
Reported by Svace static analyzer.

Modules/_datetimemodule.c

index 2522b65f1168e7bc8b1821ba23523ba5f804f2f7..3ba700bbf852cfaf09d2d89ef8864c59e12f4fe7 100644 (file)
@@ -1290,8 +1290,11 @@ tzinfo_from_isoformat_results(int rv, int tzoffset, int tz_useconds) {
         }
 
         PyObject *delta = new_delta(0, tzoffset, tz_useconds, 1);
+        if (delta == NULL) {
+            return NULL;
+        }
         tzinfo = new_timezone(delta, NULL);
-        Py_XDECREF(delta);
+        Py_DECREF(delta);
     } else {
         tzinfo = Py_None;
         Py_INCREF(Py_None);