]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
[3.7] bpo-39831: Fix a reference leak in PyErr_WarnEx(). (GH-18750). (GH-18760)
authorPablo Galindo <Pablogsal@gmail.com>
Tue, 3 Mar 2020 01:13:24 +0000 (01:13 +0000)
committerGitHub <noreply@github.com>
Tue, 3 Mar 2020 01:13:24 +0000 (01:13 +0000)
(cherry picked from commit 2d2f85517f8216146a2f888d1ad4d765b3be2339)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Python/_warnings.c

index e86a582a01cf44f2137852c923d3d1fddff0e9f3..1a2035eb250d59eb0fce3766eb52bc61bdfcf2d1 100644 (file)
@@ -710,7 +710,7 @@ setup_context(Py_ssize_t stack_level, PyObject **filename, int *lineno,
 
         *registry = PyDict_New();
         if (*registry == NULL)
-            return 0;
+            goto handle_error;
 
          rc = PyDict_SetItemString(globals, "__warningregistry__", *registry);
          if (rc < 0)
@@ -802,6 +802,7 @@ setup_context(Py_ssize_t stack_level, PyObject **filename, int *lineno,
        dangling reference. */
     Py_XDECREF(*registry);
     Py_XDECREF(*module);
+    Py_XDECREF(*filename);
     return 0;
 }