]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
gh-104860: Fix allow_abbrev=False for single-dash long options (GH-124340)
authorSerhiy Storchaka <storchaka@gmail.com>
Sun, 29 Sep 2024 07:44:34 +0000 (10:44 +0300)
committerGitHub <noreply@github.com>
Sun, 29 Sep 2024 07:44:34 +0000 (10:44 +0300)
Lib/argparse.py
Lib/test/test_argparse.py
Misc/NEWS.d/next/Library/2024-09-23-17-33-47.gh-issue-104860.O86OSc.rst [new file with mode: 0644]

index 690b2a9db9481b164dd8ba180115c1be04697f13..4506a5e3a378f489f2d447cbb7423f5b9e5a04a3 100644 (file)
@@ -2328,7 +2328,7 @@ class ArgumentParser(_AttributeHolder, _ActionsContainer):
                     action = self._option_string_actions[option_string]
                     tup = action, option_string, '', short_explicit_arg
                     result.append(tup)
-                elif option_string.startswith(option_prefix):
+                elif self.allow_abbrev and option_string.startswith(option_prefix):
                     action = self._option_string_actions[option_string]
                     tup = action, option_string, None, None
                     result.append(tup)
index ef05a6fefcffcce431553478d00f3980013f70d8..26e32c30b4d1045c1717cac0557a7b1cb38e0adb 100644 (file)
@@ -914,6 +914,23 @@ class TestOptionalsDisallowLongAbbreviationPrefixChars(ParserTestCase):
     ]
 
 
+class TestOptionalsDisallowSingleDashLongAbbreviation(ParserTestCase):
+    """Do not allow abbreviations of long options at all"""
+
+    parser_signature = Sig(allow_abbrev=False)
+    argument_signatures = [
+        Sig('-foo'),
+        Sig('-foodle', action='store_true'),
+        Sig('-foonly'),
+    ]
+    failures = ['-foon 3', '-food', '-food -foo 2']
+    successes = [
+        ('', NS(foo=None, foodle=False, foonly=None)),
+        ('-foo 3', NS(foo='3', foodle=False, foonly=None)),
+        ('-foonly 7 -foodle -foo 2', NS(foo='2', foodle=True, foonly='7')),
+    ]
+
+
 class TestDisallowLongAbbreviationAllowsShortGrouping(ParserTestCase):
     """Do not allow abbreviations of long options at all"""
 
diff --git a/Misc/NEWS.d/next/Library/2024-09-23-17-33-47.gh-issue-104860.O86OSc.rst b/Misc/NEWS.d/next/Library/2024-09-23-17-33-47.gh-issue-104860.O86OSc.rst
new file mode 100644 (file)
index 0000000..707c4d6
--- /dev/null
@@ -0,0 +1,2 @@
+Fix disallowing abbreviation of single-dash long options in :mod:`argparse`
+with ``allow_abbrev=False``.