]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/xe/fbdev: use the same 64-byte stride alignment as i915
authorJani Nikula <jani.nikula@intel.com>
Thu, 18 Sep 2025 08:40:51 +0000 (11:40 +0300)
committerJani Nikula <jani.nikula@intel.com>
Fri, 19 Sep 2025 06:32:36 +0000 (09:32 +0300)
For reasons unknown, xe uses XE_PAGE_SIZE alignment for
stride. Presumably it's just a confusion between stride alignment and bo
allocation size alignment. Switch to 64 byte alignment to, uh, align
with i915.

This will also be helpful in deduplicating and unifying the xe and i915
framebuffer allocation.

Link: https://lore.kernel.org/r/aLqsC87Ol_zCXOkN@intel.com
Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://lore.kernel.org/r/7f4972104de8b179d5724ae83892ee294d3f3fd3.1758184771.git.jani.nikula@intel.com
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/xe/display/intel_fbdev_fb.c

index d96ba2b510655dee52d663b558ac0e5b34bf434f..7dd581da7b79d153a7af49ee64888bc56b840787 100644 (file)
@@ -33,7 +33,7 @@ struct intel_framebuffer *intel_fbdev_fb_alloc(struct drm_fb_helper *helper,
        mode_cmd.height = sizes->surface_height;
 
        mode_cmd.pitches[0] = ALIGN(mode_cmd.width *
-                                   DIV_ROUND_UP(sizes->surface_bpp, 8), XE_PAGE_SIZE);
+                                   DIV_ROUND_UP(sizes->surface_bpp, 8), 64);
        mode_cmd.pixel_format = drm_mode_legacy_fb_format(sizes->surface_bpp,
                                                          sizes->surface_depth);