]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
dmaengine: mxs-dma: Use dev_err_probe() to simplify code
authorFrank Li <Frank.Li@nxp.com>
Wed, 25 Feb 2026 21:41:40 +0000 (16:41 -0500)
committerVinod Koul <vkoul@kernel.org>
Mon, 9 Mar 2026 11:20:47 +0000 (12:20 +0100)
Use dev_err_probe() simplify code. No functional change.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
Link: https://patch.msgid.link/20260225-mxsdma-module-v3-4-8f798b13baa6@nxp.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/mxs-dma.c

index 5340f831ae9dbf5423564e070735f5289c8d49de..e05bca738d2efe45d385dfb2180dd1c75b00163e 100644 (file)
@@ -753,10 +753,8 @@ static int mxs_dma_probe(struct platform_device *pdev)
                return -ENOMEM;
 
        ret = of_property_read_u32(np, "dma-channels", &mxs_dma->nr_channels);
-       if (ret) {
-               dev_err(dev, "failed to read dma-channels\n");
-               return ret;
-       }
+       if (ret)
+               return dev_err_probe(dev, ret, "failed to read dma-channels\n");
 
        dma_type = (struct mxs_dma_type *)of_device_get_match_data(dev);
        mxs_dma->type = dma_type->type;
@@ -816,17 +814,13 @@ static int mxs_dma_probe(struct platform_device *pdev)
        mxs_dma->dma_device.device_issue_pending = mxs_dma_enable_chan;
 
        ret = dmaenginem_async_device_register(&mxs_dma->dma_device);
-       if (ret) {
-               dev_err(dev, "unable to register\n");
-               return ret;
-       }
+       if (ret)
+               return dev_err_probe(dev, ret, "unable to register\n");
 
        ret = of_dma_controller_register(np, mxs_dma_xlate, mxs_dma);
-       if (ret) {
-               dev_err(dev,
-                       "failed to register controller\n");
-               return ret;
-       }
+       if (ret)
+               return dev_err_probe(dev, ret,
+                                    "failed to register controller\n");
 
        dev_info(dev, "initialized\n");