bng_en: add support for link async events

Register for firmware asynchronous events, including link-status,
link-speed, and PHY configuration changes. Upon event reception,
re-query the PHY and update ethtool settings accordingly.

Signed-off-by: Bhargava Marreddy <bhargava.marreddy@broadcom.com>
Reviewed-by: Vikas Gupta <vikas.gupta@broadcom.com>
Reviewed-by: Rajashekar Hudumula <rajashekar.hudumula@broadcom.com>
Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
Link: https://patch.msgid.link/20260406180420.279470-6-bhargava.marreddy@broadcom.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_hwrm_lib.c b/drivers/net/ethernet/broadcom/bnge/bnge_hwrm_lib.c
index c2e47b1d703402a14e44ff5fc1d0f44db693479c..83c0b16c3e81f80ca15a567e2fab7756de118b98 100644 (file)
--- a/drivers/net/ethernet/broadcom/bnge/bnge_hwrm_lib.c
+++ b/drivers/net/ethernet/broadcom/bnge/bnge_hwrm_lib.c
@@ -15,6 +15,13 @@
 #include "bnge_rmem.h"
 #include "bnge_resc.h"
 
+static const u16 bnge_async_events_arr[] = {
+       ASYNC_EVENT_CMPL_EVENT_ID_LINK_STATUS_CHANGE,
+       ASYNC_EVENT_CMPL_EVENT_ID_LINK_SPEED_CHANGE,
+       ASYNC_EVENT_CMPL_EVENT_ID_LINK_SPEED_CFG_CHANGE,
+       ASYNC_EVENT_CMPL_EVENT_ID_PORT_PHY_CFG_CHANGE,
+};
+
 int bnge_hwrm_ver_get(struct bnge_dev *bd)
 {
        u32 dev_caps_cfg, hwrm_ver, hwrm_spec_code;
@@ -166,10 +173,12 @@ int bnge_hwrm_fw_set_time(struct bnge_dev *bd)
 
 int bnge_hwrm_func_drv_rgtr(struct bnge_dev *bd)
 {
+       DECLARE_BITMAP(async_events_bmap, 256);
        struct hwrm_func_drv_rgtr_output *resp;
        struct hwrm_func_drv_rgtr_input *req;
+       u32 events[8];
        u32 flags;
-       int rc;
+       int rc, i;
 
        rc = bnge_hwrm_req_init(bd, req, HWRM_FUNC_DRV_RGTR);
        if (rc)
@@ -190,6 +199,14 @@ int bnge_hwrm_func_drv_rgtr(struct bnge_dev *bd)
        req->ver_min = cpu_to_le16(DRV_VER_MIN);
        req->ver_upd = cpu_to_le16(DRV_VER_UPD);
 
+       memset(async_events_bmap, 0, sizeof(async_events_bmap));
+       for (i = 0; i < ARRAY_SIZE(bnge_async_events_arr); i++)
+               __set_bit(bnge_async_events_arr[i], async_events_bmap);
+
+       bitmap_to_arr32(events, async_events_bmap, 256);
+       for (i = 0; i < ARRAY_SIZE(req->async_event_fwd); i++)
+               req->async_event_fwd[i] |= cpu_to_le32(events[i]);
+
        resp = bnge_hwrm_req_hold(bd, req);
        rc = bnge_hwrm_req_send(bd, req);
        if (!rc) {

diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_link.c b/drivers/net/ethernet/broadcom/bnge/bnge_link.c
index 2e2aaa7644430b303756a0b7be66313a79a05a25..3b0dfcf2737620935d5c754813bd849895c83594 100644 (file)
--- a/drivers/net/ethernet/broadcom/bnge/bnge_link.c
+++ b/drivers/net/ethernet/broadcom/bnge/bnge_link.c
@@ -1112,3 +1112,21 @@ int bnge_set_link_ksettings(struct net_device *dev,
 set_setting_exit:
        return rc;
 }
+
+void bnge_link_async_event_process(struct bnge_net *bn, u16 event_id)
+{
+       switch (event_id) {
+       case ASYNC_EVENT_CMPL_EVENT_ID_LINK_SPEED_CFG_CHANGE:
+               set_bit(BNGE_LINK_SPEED_CHNG_SP_EVENT, &bn->sp_event);
+               break;
+       case ASYNC_EVENT_CMPL_EVENT_ID_LINK_SPEED_CHANGE:
+       case ASYNC_EVENT_CMPL_EVENT_ID_PORT_PHY_CFG_CHANGE:
+               set_bit(BNGE_LINK_CFG_CHANGE_SP_EVENT, &bn->sp_event);
+               break;
+       case ASYNC_EVENT_CMPL_EVENT_ID_LINK_STATUS_CHANGE:
+               set_bit(BNGE_LINK_CHNG_SP_EVENT, &bn->sp_event);
+               break;
+       default:
+               break;
+       }
+}

diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_link.h b/drivers/net/ethernet/broadcom/bnge/bnge_link.h
index a0e6e62e03d84b3ce4b6e8b82f330405b2e78157..ccaf343aa0183ece44f8156824add1beb0cd7731 100644 (file)
--- a/drivers/net/ethernet/broadcom/bnge/bnge_link.h
+++ b/drivers/net/ethernet/broadcom/bnge/bnge_link.h
@@ -169,4 +169,5 @@ int bnge_set_link_ksettings(struct net_device *dev,
 int bnge_get_link_ksettings(struct net_device *dev,
                            struct ethtool_link_ksettings *lk_ksettings);
 u32 bnge_get_link(struct net_device *dev);
+void bnge_link_async_event_process(struct bnge_net *bn, u16 event_id);
 #endif /* _BNGE_LINK_H_ */

diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c
index 185f5bfce1d5700bf46f4a4cf0fa665fe9809ddd..90458b323120966202bc5fd715bbe53f9ed2722a 100644 (file)
--- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c
+++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c
@@ -136,6 +136,7 @@ static void bnge_timer(struct timer_list *t)
 static void bnge_sp_task(struct work_struct *work)
 {
        struct bnge_net *bn = container_of(work, struct bnge_net, sp_task);
+       bool speed_chng, cfg_chng, link_chng;
        struct bnge_dev *bd = bn->bd;
 
        netdev_lock(bn->netdev);
@@ -156,6 +157,28 @@ static void bnge_sp_task(struct work_struct *work)
                }
        }
 
+       speed_chng = test_and_clear_bit(BNGE_LINK_SPEED_CHNG_SP_EVENT,
+                                       &bn->sp_event);
+       cfg_chng = test_and_clear_bit(BNGE_LINK_CFG_CHANGE_SP_EVENT,
+                                     &bn->sp_event);
+       link_chng = test_and_clear_bit(BNGE_LINK_CHNG_SP_EVENT,
+                                      &bn->sp_event);
+
+       if (speed_chng || cfg_chng || link_chng) {
+               int rc;
+
+               if (speed_chng)
+                       bnge_hwrm_phy_qcaps(bd);
+
+               rc = bnge_update_link(bn, true);
+               if (rc)
+                       netdev_err(bn->netdev, "SP task cannot update link (rc: %d)\n",
+                                  rc);
+
+               if (speed_chng || cfg_chng)
+                       bnge_init_ethtool_link_settings(bn);
+       }
+
        netdev_unlock(bn->netdev);
 }
 

diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_txrx.c b/drivers/net/ethernet/broadcom/bnge/bnge_txrx.c
index a2616f03755723bce25d3a2c55940c72704b904d..7d45e057f2e82069b3b54936a02e4c955b2787c8 100644 (file)
--- a/drivers/net/ethernet/broadcom/bnge/bnge_txrx.c
+++ b/drivers/net/ethernet/broadcom/bnge/bnge_txrx.c
@@ -1128,6 +1128,29 @@ static void __bnge_poll_work_done(struct bnge_net *bn, struct bnge_napi *bnapi,
        }
 }
 
+static void bnge_async_event_process(struct bnge_net *bn,
+                                    struct hwrm_async_event_cmpl *cmpl)
+{
+       u16 event_id = le16_to_cpu(cmpl->event_id);
+       u32 data1 = le32_to_cpu(cmpl->event_data1);
+       u32 data2 = le32_to_cpu(cmpl->event_data2);
+
+       netdev_dbg(bn->netdev, "hwrm event 0x%x {0x%x, 0x%x}\n",
+                  event_id, data1, data2);
+
+       switch (event_id) {
+       case ASYNC_EVENT_CMPL_EVENT_ID_LINK_SPEED_CFG_CHANGE:
+       case ASYNC_EVENT_CMPL_EVENT_ID_LINK_SPEED_CHANGE:
+       case ASYNC_EVENT_CMPL_EVENT_ID_PORT_PHY_CFG_CHANGE:
+       case ASYNC_EVENT_CMPL_EVENT_ID_LINK_STATUS_CHANGE:
+               bnge_link_async_event_process(bn, event_id);
+               break;
+       default:
+               return;
+       }
+       __bnge_queue_sp_work(bn);
+}
+
 static void
 bnge_hwrm_update_token(struct bnge_dev *bd, u16 seq_id,
                       enum bnge_hwrm_wait_state state)
@@ -1146,7 +1169,7 @@ bnge_hwrm_update_token(struct bnge_dev *bd, u16 seq_id,
        dev_err(bd->dev, "Invalid hwrm seq id %d\n", seq_id);
 }
 
-static int bnge_hwrm_handler(struct bnge_dev *bd, struct tx_cmp *txcmp)
+static int bnge_hwrm_handler(struct bnge_net *bn, struct tx_cmp *txcmp)
 {
        struct hwrm_cmpl *h_cmpl = (struct hwrm_cmpl *)txcmp;
        u16 cmpl_type = TX_CMP_TYPE(txcmp), seq_id;
@@ -1154,10 +1177,14 @@ static int bnge_hwrm_handler(struct bnge_dev *bd, struct tx_cmp *txcmp)
        switch (cmpl_type) {
        case CMPL_BASE_TYPE_HWRM_DONE:
                seq_id = le16_to_cpu(h_cmpl->sequence_id);
-               bnge_hwrm_update_token(bd, seq_id, BNGE_HWRM_COMPLETE);
+               bnge_hwrm_update_token(bn->bd, seq_id, BNGE_HWRM_COMPLETE);
                break;
 
        case CMPL_BASE_TYPE_HWRM_ASYNC_EVENT:
+               bnge_async_event_process(bn,
+                                        (struct hwrm_async_event_cmpl *)txcmp);
+               break;
+
        default:
                break;
        }
@@ -1235,7 +1262,7 @@ static int __bnge_poll_work(struct bnge_net *bn, struct bnge_cp_ring_info *cpr,
                } else if (unlikely(cmp_type == CMPL_BASE_TYPE_HWRM_DONE ||
                                    cmp_type == CMPL_BASE_TYPE_HWRM_FWD_REQ ||
                                    cmp_type == CMPL_BA_TY_HWRM_ASY_EVT)) {
-                       bnge_hwrm_handler(bn->bd, txcmp);
+                       bnge_hwrm_handler(bn, txcmp);
                }
                raw_cons = NEXT_RAW_CMP(raw_cons);
 
@@ -1355,7 +1382,7 @@ int bnge_napi_poll(struct napi_struct *napi, int budget)
                                                      budget - work_done);
                        nqr->has_more_work |= cpr->has_more_work;
                } else {
-                       bnge_hwrm_handler(bn->bd, (struct tx_cmp *)nqcmp);
+                       bnge_hwrm_handler(bn, (struct tx_cmp *)nqcmp);
                }
                raw_cons = NEXT_RAW_CMP(raw_cons);
        }