]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
bpo-42773: fix tests not being run on pushes (GH-24004)
authorFilipe Laíns <lains@riseup.net>
Wed, 30 Dec 2020 14:53:58 +0000 (14:53 +0000)
committerGitHub <noreply@github.com>
Wed, 30 Dec 2020 14:53:58 +0000 (06:53 -0800)
There was a typo, we were checking if the "GITHUB_BASE_REF" string
literal was empty instead of the $GITHUB_BASE_REF value. When
$GITHUB_BASE_REF is empty, the action that triggered the run was not a
pull request, so we always run the full test suite.

Signed-off-by: Filipe Laíns <lains@riseup.net>
.github/workflows/build.yml

index 1b865a17b09dd0e44805485e6ae6d6166de5fce5..6f05310e6e5862d9e5e96dada4f00e8f1745fb41 100644 (file)
@@ -28,7 +28,7 @@ jobs:
       - name: Check for source changes
         id: check
         run: |
-          if [ -z "GITHUB_BASE_REF" ]; then
+          if [ -z "$GITHUB_BASE_REF" ]; then
             echo '::set-output name=run_tests::true'
           else
             git fetch origin $GITHUB_BASE_REF --depth=1