RDMA/device: Return error earlier if port in not valid

[ Upstream commit 917918f57a7b139c043e78c502876f2c286f4f0a ]

There is no need to allocate port data if port provided is not valid.

Fixes: c2261dd76b54 ("RDMA/device: Add ib_device_set_netdev() as an alternative to get_netdev")
Link: https://lore.kernel.org/r/022047a8b16988fc88d4426da50bf60a4833311b.1719235449.git.leon@kernel.org
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c
index 55aa7aa32d4ab3e6d6710401bed35bf5916e41fe..e0cff28bb0ef183ed3784ed74fa92bc3107ac523 100644 (file)
--- a/drivers/infiniband/core/device.c
+++ b/drivers/infiniband/core/device.c
@@ -2146,6 +2146,9 @@ int ib_device_set_netdev(struct ib_device *ib_dev, struct net_device *ndev,
        unsigned long flags;
        int ret;
 
+       if (!rdma_is_port_valid(ib_dev, port))
+               return -EINVAL;
+
        /*
         * Drivers wish to call this before ib_register_driver, so we have to
         * setup the port data early.
@@ -2154,9 +2157,6 @@ int ib_device_set_netdev(struct ib_device *ib_dev, struct net_device *ndev,
        if (ret)
                return ret;
 
-       if (!rdma_is_port_valid(ib_dev, port))
-               return -EINVAL;
-
        pdata = &ib_dev->port_data[port];
        spin_lock_irqsave(&pdata->netdev_lock, flags);
        old_ndev = rcu_dereference_protected(