]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
mmc: sdhci-pxav3: fix error handling of sdhci_add_host
authorXiang Wang <wangx@marvell.com>
Wed, 16 Jul 2014 07:50:09 +0000 (15:50 +0800)
committerLuis Henriques <luis.henriques@canonical.com>
Thu, 22 Jan 2015 16:33:27 +0000 (16:33 +0000)
commit 87d2163dae1f2388c7ccda5269be8d58e24382dd upstream.

Commit 0dcaa2499b7d111bd70da5b0976c34210c850fb3 improved error
handling of sdhci_add_host. However, "err_of_parse" and "err_cd_req"
should be placed after "pm_runtime_disable(&pdev->dev)".

Signed-off-by: Xiang Wang <wangx@marvell.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
[ luis: 3.16-stable prereq for:
  aa8165f91442 "mmc: sdhci-pxav3: do the mbus window configuration after enabling clocks" ]
Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
drivers/mmc/host/sdhci-pxav3.c

index 10846b04809a792dc2d08480661788c1002f3dfc..6675be324cbcb04ca942e584200f9d07fe3a241d 100644 (file)
@@ -382,11 +382,11 @@ static int sdhci_pxav3_probe(struct platform_device *pdev)
 
        return 0;
 
-err_of_parse:
-err_cd_req:
 err_add_host:
        pm_runtime_put_sync(&pdev->dev);
        pm_runtime_disable(&pdev->dev);
+err_of_parse:
+err_cd_req:
        clk_disable_unprepare(clk);
        clk_put(clk);
 err_clk_get: