]> git.ipfire.org Git - thirdparty/asterisk.git/commitdiff
Fix xmldoc memory leak
authorKinsey Moore <kmoore@digium.com>
Tue, 20 Aug 2013 14:24:52 +0000 (14:24 +0000)
committerKinsey Moore <kmoore@digium.com>
Tue, 20 Aug 2013 14:24:52 +0000 (14:24 +0000)
This fixes a single-attribute memory leak that was occurring when the
"required" attribute was not true.

(closes issue ASTERISK-22249)
Reported by: Corey Farrell
Tested by: Corey Farrell
Patches:
    xmldoc-free_attr_required.patch uploaded by Corey Farrell

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@397064 65c4cc65-6c06-0410-ace0-fbb531ad65f3

main/xmldoc.c

index 8e2a1f13b4a0faf41da19ed9f0901a0d309a89a7..25f1fb60047a5f71002f243b63d3057e57879fcb 100644 (file)
@@ -755,6 +755,7 @@ static char *xmldoc_get_syntax_fun(struct ast_xml_node *rootnode, const char *ro
                                if ((paramtype = ast_xml_get_attribute(node, "required"))) {
                                        if (!ast_true(paramtype)) {
                                                optmidnode = 1;
+                                               ast_xml_free_attr(paramtype);
                                                break;
                                        }
                                        ast_xml_free_attr(paramtype);